Mention mssfix default value in the man page
PATCH 1/1 Mention mssfix default value in the man page
The man page does not mention that the default value of "mssfix" is 1450.
openvpn.8 2010-04-15 19:43:53.000000000 +0100 renamed from openvpn.8 2010-02-28 22:17:45.000000000 +0000 +2 -1
@@ -1223,7 +1223,8 @@ their send packet sizes such that after the resulting UDP packet size that OpenVPN sends to its peer will not exceed .B max -bytes. +bytes. The default value is +.B 1450. The .B max
Signature · 1 line
D.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 5 lines · Davide Brini
The man page does not mention that the default value of "mssfix" is 1450.
openvpn.8 2010-04-15 19:43:53.000000000 +0100 their send packet sizes such that after · line 1230
Quoted 9 lines
openvpn.8 2010-04-15 19:43:53.000000000 +0100 renamed from openvpn.8 2010-02-28 22:17:45.000000000 +0000 +2
-1@@ -1223,7 +1223,8 @@ their send packet sizes such that after the resulting UDP packet size that OpenVPN sends to its peer will not exceed .B max -bytes. +bytes. The default value is +.B 1450. The .B max
ACK.
Added as commit 38025abb47f74363c3ee87ca7265e99a4055459e to bugfix2.1 and merged into allmerged.
kind regards,
David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvLh1MACgkQDC186MBRfro4qwCfbNYIFyLe1b5jyxrKuo32Zgoh DAgAnRaxn8RUfls7G6gFE/E+t/VYJetS
=bP2r
-----END PGP SIGNATURE-----
Quoted 2 lines · On Sunday 18 Apr 2010 23:27:31 David Sommerseth wrote:
Added as commit
38025abb47f74363c3ee87ca7265e99a4055459eto bugfix2.1 and merged into allmerged.
Thanks. Though I understand it's not critical, in case you didn't notice, there's also another pending patch I submitted more than one month ago now, about the removal of bashisms in the user-contributed scripts client.up and client.down (plus adding other functionalities):
http://article.gmane.org/gmane.network.openvpn.devel/3343
I'm reattaching it here, but see the original message for some discussion/explanation.
Signature · 1 line
D.
contrib/pull-resolv-conf/client.up +56 -31
@@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # Copyright (c) 2005-2009 OpenVPN Technologies, Inc. # Licensed under the GPL version 2
@@ -14,7 +14,6 @@ # Place this in /etc/openvpn/client.up # Then, add the following to your /etc/openvpn/<clientconfig>.conf: # client -# pull dhcp-options # up /etc/openvpn/client.up # Next, "chmod a+x /etc/openvpn/client.up"
@@ -22,8 +21,8 @@ # Note that this script is best served with the companion "client.down" # script. -# Only tested on Gentoo Linux 2005.0 with OpenVPN 2.0 -# It should work with any GNU/Linux with /etc/resolv.conf +# Tested under Debian lenny with OpenVPN 2.1_rc11 +# It should work with any UNIX with a POSIX sh, /etc/resolv.conf or resolvconf # This runs with the context of the OpenVPN UID/GID # at the time of execution. This generally means that
@@ -38,38 +37,64 @@ # init variables i=1 -j=1 -unset fopt -unset dns -unset opt - -# Convert ENVs to an array - -while fopt=foreign_option_$i; [ -n "${!fopt}" ]; do -{ - opt[i-1]=${!fopt} - case ${opt[i-1]} in - *DOMAIN* ) domain=`echo ${opt[i-1]} | \ - sed -e 's/dhcp-option DOMAIN //g'` ;; - *DNS* ) dns[j-1]=`echo ${opt[i-1]} | \ - sed -e 's/dhcp-option DNS //g'` - let j++ ;; +domains= +fopt= +ndoms=0 +nns=0 +nl=' +' + +# $foreign_option_<n> is something like +# "dhcp-option DOMAIN example.com" (multiple allowed) +# or +# "dhcp-option DNS 10.10.10.10" (multiple allowed) + +# each DNS option becomes a "nameserver" option in resolv.con +# if we get one DOMAIN, that becomes "domain" in resolv.conf +# if we get multiple DOMAINS, those become "search" lines in resolv.conf + +while true; do + eval fopt=\$foreign_option_${i} + [ -z "${fopt}" ] && break + + case ${fopt} in + dhcp-option\ DOMAIN\ *) + ndoms=$((ndoms + 1)) + domains="${domains} ${fopt#dhcp-option DOMAIN }" + ;; + dhcp-option\ DNS\ *) + nns=$((nns + 1)) + if [ $nns -le 3 ]; then + dns="${dns}${dns:+$nl}nameserver ${fopt#dhcp-option DNS }" + else + printf "%s\n" "Too many nameservers - ignoring after third" >&2 + fi + ;; + *) + printf "%s\n" "Unknown option \"${fopt}\" - ignored" >&2 + ;; esac - let i++ -} + i=$((i + 1)) done -# Now, do the work - -if [ -n "${dns[*]}" ]; then - for i in "${dns[@]}"; do - sed -i -e "1,1 i nameserver ${i}" /etc/resolv.conf || die - done +ds=domain +if [ $ndoms -gt 1 ]; then + ds=search fi -if [ -n "${domain}" ]; then - sed -i -e "$j,1 i search ${domain}" /etc/resolv.conf || die +# This is the complete file - "$domains" has a leading space already +out="# resolv.conf autogenerated by ${0} (${1})${nl}${dns}${nl}${ds}${domains}" + +# use resolvconf if it's available +if [ -x /sbin/resolvconf ] ; then + printf "%s\n" "${out}" | /sbin/resolvconf -a "${1}" +else + # Preserve the existing resolv.conf + if [ -e /etc/resolv.conf ] ; then + cp /etc/resolv.conf /etc/resolv.conf.ovpnsave + fi + printf "%s\n" "${out}" > /etc/resolv.conf + chmod 644 /etc/resolv.conf fi -# all done... exit 0
contrib/pull-resolv-conf/client.down +8 -38
64 lines not on this page · raw message
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 10 lines · Davide Brini
Quoted 2 lines · On Sunday 18 Apr 2010 23:27:31 David Sommerseth wrote:
Added as commit
38025abb47f74363c3ee87ca7265e99a4055459eto bugfix2.1 and merged into allmerged.Thanks. Though I understand it's not critical, in case you didn't notice, there's also another pending patch I submitted more than one month ago now, about the removal of bashisms in the user-contributed scripts client.up and client.down (plus adding other functionalities):
Quoted 4 lines
http://article.gmane.org/gmane.network.openvpn.devel/3343
I'm reattaching it here, but see the original message for some discussion/explanation.
Aikes! I'm sorry for having failed to catch this one! I'm going to test it out on one of my Fedora boxes within a couple of days. If it plays nicely, I'll give it an ACK and will include it!
Anyway, it's now in my "queue box" :)
David S.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkvMJCYACgkQDC186MBRfrq3bgCgoSpsaDQ7qZmWzH5eucF5UNrN SykAn2OgmifrzWVvJRSCLU1D2cNZ99Iu
=QUJm
-----END PGP SIGNATURE-----