Skip to contentSkip to conversation

pull request: wireless-2.6 2010-04-15

PATCH Applied John W. Linville 4 participants 4 messages Apr 15, 2010 – Apr 28, 2010 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Dave,

Another fix intended for 2.6.34...without it some firmware wierdness can induce the driver into hanging the box... :-(

Please let me know if there are problems!

Thanks,

John

---

The following changes since commit 4eaa0e3c869acd5dbc7c2e3818a9ae9cbf221d27:
Eric Dumazet (1):
fib: suppress lockdep-RCU false positive in FIB trie.

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git master

Johannes Berg (1):
iwlwifi: work around bogus active chains detection

 drivers/net/wireless/iwlwifi/iwl-calib.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
drivers/net/wireless/iwlwifi/iwl-calib.c +12 -0
index 845831a..64de42b 100644
@@ -807,6 +807,18 @@ void iwl_chain_noise_calibration(struct iwl_priv *priv,
 		}
 	}
 
+	/*
+	 * The above algorithm sometimes fails when the ucode
+	 * reports 0 for all chains. It's not clear why that
+	 * happens to start with, but it is then causing trouble
+	 * because this can make us enable more chains than the
+	 * hardware really has.
+	 *
+	 * To be safe, simply mask out any chains that we know
+	 * are not on the device.
+	 */
+	active_chains &= priv->hw_params.valid_rx_ant;
+
 	num_tx_chains = 0;
 	for (i = 0; i < NUM_RX_CHAINS; i++) {
 		/* loops on all the bits of
Signature · 2 lines
John W. Linville		Someday the world will need a hero, and you
[email protected]			might be all we have.  Be ready.
maintainer
#1 lore raw

From: "John W. Linville" <[email protected]>
Date: Thu, 15 Apr 2010 16:03:31 -0400

Quoted 4 lines

Another fix intended for 2.6.34...without it some firmware wierdness can induce the driver into hanging the box... :-(

Please let me know if there are problems!

Pulled, thanks.

A message that is not in the archive (sent off-list or not yet received): 20100415.142907.68448693.davem-fT/PcQaiUtIeIZ0/[email protected]

#3 lore raw

Hi David,

in your merge in 5c01d5669356e13f0fb468944c1dd4c6a7e978ad you added "int i;" into wl1271_main.c which is unused in that function.

This patch fixes the merge problem:

drivers/net/wireless/wl12xx/wl1271_main.c +0 -1
@@ -1311,7 +1311,6 @@
 	struct wl1271_filter_params *fp;
 	struct netdev_hw_addr *ha;
 	struct wl1271 *wl = hw->priv;
-	int i;
 
 	if (unlikely(wl->state == WL1271_STATE_OFF))
 		return 0;
Quoted 6 lines · David Miller

From: "John W. Linville" <[email protected]>
Date: Thu, 15 Apr 2010 16:03:31 -0400

Quoted 3 lines

Another fix intended for 2.6.34...without it some firmware wierdness can induce the driver into hanging the box... :-(

Quoted 7 lines
Quoted 1 line

Please let me know if there are problems!

Pulled, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4BD8A6B4.20603-5/[email protected]

Applied
#5 lore raw

From: Hauke Mehrtens <[email protected]>
Date: Wed, 28 Apr 2010 23:20:52 +0200

Quoted 8 lines

Hi David,

in your merge in 5c01d5669356e13f0fb468944c1dd4c6a7e978ad you added "int i;" into wl1271_main.c which is unused in that function.

This patch fixes the merge problem:

Applied, thanks.