Skip to contentSkip to conversation

libata-sff: kill ata_bus_reset()

PATCH Applied Sergei Shtylyov 3 participants 3 messages Apr 22, 2010 – Apr 23, 2010

Subsystems (2)
Documentation libata
lore
Share & tools
lore

Sergei Shtylyov

author
#0 lore raw

PATCH 1/1 libata-sff: kill ata_bus_reset()

... since I see no callers of it.

Signed-off-by Sergei Shtylyov <[email protected]>

---
The patch is against the recent Linus' tree.

 Documentation/DocBook/libata.tmpl |    6 --
 drivers/ata/libata-sff.c          |   94 --------------------------------------
 include/linux/libata.h            |    1 
 3 files changed, 2 insertions(+), 99 deletions(-)
Documentation/DocBook/libata.tmpl +2 -4
Index: linux-2.6/Documentation/DocBook/libata.tmpl
===================================================================
@@ -81,16 +81,14 @@ void (*port_disable) (struct ata_port *)
 	</programlisting>
 
 	<para>
-	Called from ata_bus_probe() and ata_bus_reset() error paths,
-	as well as when unregistering from the SCSI module (rmmod, hot
-	unplug).
+	Called from ata_bus_probe() error path, as well as when
+	unregistering from the SCSI module (rmmod, hot unplug).
 	This function should do whatever needs to be done to take the
 	port out of use.  In most cases, ata_port_disable() can be used
 	as this hook.
 	</para>
 	<para>
 	Called from ata_bus_probe() on a failed probe.
-	Called from ata_bus_reset() on a failed bus reset.
 	Called from ata_scsi_release().
 	</para>
drivers/ata/libata-sff.c +0 -94

100 lines not on this page · raw message

include/linux/libata.h +0 -1
Index: linux-2.6/include/linux/libata.h
===================================================================
@@ -1631,7 +1631,6 @@ extern void ata_bmdma_setup(struct ata_q
 extern void ata_bmdma_start(struct ata_queued_cmd *qc);
 extern void ata_bmdma_stop(struct ata_queued_cmd *qc);
 extern u8 ata_bmdma_status(struct ata_port *ap);
-extern void ata_bus_reset(struct ata_port *ap);
 
 #ifdef CONFIG_PCI
 extern int ata_pci_bmdma_clear_simplex(struct pci_dev *pdev);
Applied
#1 lore raw
Quoted 11 lines · Sergei Shtylyov

... since I see no callers of it.

Signed-off-by Sergei Shtylyov<[email protected]>

---
The patch is against the recent Linus' tree.

  Documentation/DocBook/libata.tmpl |    6 --
  drivers/ata/libata-sff.c          |   94 --------------------------------------
  include/linux/libata.h            |    1
  3 files changed, 2 insertions(+), 99 deletions(-)

applied