Skip to contentSkip to conversation

drivers/gpu/drm/via/via_video.c: fix off by one issue

PATCH In review [email protected] 2 participants 2 messages Apr 27, 2010 – Apr 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/5 drivers/gpu/drm/via/via_video.c: fix off by one issue

From: Dan Carpenter <[email protected]>

"fx->lock" is used as the index in "dev_priv->decoder_queue[fx->lock]" which is an array of "VIA_NR_XVMC_LOCKS" elements.

---

 drivers/gpu/drm/via/via_video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/via/via_video.c renamed from drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue +1 -1
diff -puN drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue drivers/gpu/drm/via/via_video.c
@@ -75,7 +75,7 @@ int via_decoder_futex(struct drm_device 
 
 	DRM_DEBUG("\n");
 
-	if (fx->lock > VIA_NR_XVMC_LOCKS)
+	if (fx->lock >= VIA_NR_XVMC_LOCKS)
 		return -EFAULT;
 
 	lock = (volatile int *)XVMCLOCKPTR(sAPriv, fx->lock);

_

------------------------------------------------------------------------------
--

Acked-by on v1 2/5
#1 lore raw
Quoted 9 lines · [email protected] wrote:

From: Dan Carpenter <[email protected]>

"fx->lock" is used as the index in "dev_priv->decoder_queue[fx->lock]" which is an array of "VIA_NR_XVMC_LOCKS" elements.

Quoted 19 lines

---

 drivers/gpu/drm/via/via_video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue drivers/gpu/drm/via/via_video.c

drivers/gpu/drm/via/via_video.c renamed from drivers/gpu/drm/via/via_video.c~drivers-gpu-drm-via-via_videoc-fix-off-by-one-issue +1 -1
@@ -75,7 +75,7 @@ int via_decoder_futex(struct drm_device 
 
 	DRM_DEBUG("\n");
 
-	if (fx->lock > VIA_NR_XVMC_LOCKS)
+	if (fx->lock >= VIA_NR_XVMC_LOCKS)
 		return -EFAULT;
 
 	lock = (volatile int *)XVMCLOCKPTR(sAPriv, fx->lock);

_

Quoted 7 lines

------------------------------------------------------------------------------
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel

------------------------------------------------------------------------------
--