Skip to contentSkip to conversation

drivers/media/video: avoid NULL dereference

PATCH In review [email protected] 1 participant 1 message Apr 27, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 4/11 drivers/media/video: avoid NULL dereference

From: Julia Lawall <[email protected]>

It seems impossible for ov to be NULL at this point.

The semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E, E1;
identifier f;
statement S1,S3;
iterator iter;
@@

if ((E == NULL && ...) || ...)
{

  ... when != false ((E == NULL && ...) || ...)
      when != true  ((E != NULL && ...) || ...)
      when != iter(E,...) S1
      when != E = E1

(
sizeof(E->f)
|
* E->f
)
... when any
return ...;
}
else S3
// </smpl>

Cc Mark McClelland <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>

---

 drivers/media/video/ov511.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/media/video/ov511.c renamed from drivers/media/video/ov511.c~drivers-media-video-avoid-null-dereference +0 -5
diff -puN drivers/media/video/ov511.c~drivers-media-video-avoid-null-dereference drivers/media/video/ov511.c
@@ -5916,11 +5916,6 @@ ov51x_disconnect(struct usb_interface *i
 	mutex_lock(&ov->lock);
 	usb_set_intfdata (intf, NULL);
 
-	if (!ov) {
-		mutex_unlock(&ov->lock);
-		return;
-	}
-
 	/* Free device number */
 	ov511_devused &= ~(1 << ov->nr);
 

_