vfs: clarify that nonseekable_open() will never fail

PATCH New [email protected] 1 participant 1 message Apr 27, 2010 VFS

lore

Share & tools

lore

[email protected]

author

2010-04-27 21:24 UTC #0 lore raw

PATCH 6/7 vfs: clarify that nonseekable_open() will never fail

From: Dmitry Torokhov <[email protected]>

Signed-off-by Dmitry Torokhov <[email protected]>

Acked-by Arnd Bergmann <[email protected]>

Acked-by John Kacur <[email protected]>

Cc Al Viro <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 fs/open.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

fs/open.c renamed from fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail +3 -1

diff -puN fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail fs/open.c
@@ -1198,7 +1198,9 @@ EXPORT_SYMBOL(generic_file_open);
 
 /*
  * This is used by subsystems that don't want seekable
- * file descriptors
+ * file descriptors. The function is not supposed to ever fail, the only
+ * reason it returns an 'int' and not 'void' is so that it can be plugged
+ * directly into file_operations structure.
  */
 int nonseekable_open(struct inode *inode, struct file *filp)
 {