Skip to contentSkip to conversation

perf_event: Use UTF-8 copyright symbol instead of \251

PATCH In review Paul Mackerras 3 participants 3 messages May 1, 2010 – May 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf_event: Use UTF-8 copyright symbol instead of \251

As noted by Tejun Heo, the latin-1 copyright character \251 is invalid in ASCII or UTF-8. This changes the character to its UTF-8 encoding in order to avoid problems with editors and other tools.

---

kernel/perf_event.c +1 -1
index 9dbe8cd..d46a277 100644
@@ -4,7 +4,7 @@
  *  Copyright (C) 2008 Thomas Gleixner <[email protected]>
  *  Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
  *  Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]>
- *  Copyright  �  2009 Paul Mackerras, IBM Corp. <[email protected]>
+ *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <[email protected]>
  *
  * For licensing details see kernel-base/COPYING
  */
#1 lore raw
Quoted 11 lines · Paul Mackerras

As noted by Tejun Heo, the latin-1 copyright character \251 is invalid in ASCII or UTF-8. This changes the character to its UTF-8 encoding in order to avoid problems with editors and other tools.

---

kernel/perf_event.c +0 -0
index 9dbe8cd..d46a277 100644

kernel/perf_event.c line 7

Quoted 4 lines
kernel/perf_event.c +0 -1
@@ -4,7 +4,7 @@
  *  Copyright (C) 2008 Thomas Gleixner <[email protected]>
  *  Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
  *  Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]>
- *  Copyright  ???  2009 Paul Mackerras, IBM Corp. <[email protected]>

Umm ... this looks odd.

kernel/perf_event.c line 7

Quoted 1 line
kernel/perf_event.c +1 -0
+ *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <[email protected]>

This seems to add \251 again :) Maybe some of your tools got confused enough?

Anyway, I have dropped the patch from Tejun for now.

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.
#2 lore raw
Quoted 6 lines · Jiri Kosina
Quoted 4 lines · Paul Mackerras

As noted by Tejun Heo, the latin-1 copyright character \251 is invalid in ASCII or UTF-8. This changes the character to its UTF-8 encoding in order to avoid problems with editors and other tools.

Quoted 13 lines

kernel/perf_event.c line 7

Quoted 11 lines

---

kernel/perf_event.c +0 -1
index 9dbe8cd..d46a277 100644
@@ -4,7 +4,7 @@
  *  Copyright (C) 2008 Thomas Gleixner <[email protected]>
  *  Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
  *  Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <[email protected]>
- *  Copyright  ???  2009 Paul Mackerras, IBM Corp. <[email protected]>

Umm ... this looks odd.

Yeah, and it didnt apply when i tried to.

Quoted 6 lines

kernel/perf_event.c line 7

Quoted 1 line
kernel/perf_event.c +1 -0
+ *  Copyright  ??  2009 Paul Mackerras, IBM Corp. <[email protected]>

This seems to add \251 again :) Maybe some of your tools got confused enough?

Anyway, I have dropped the patch from Tejun for now.

Alternatively you could pick up Paul's patch on top of Tejun's if you have already pushed the commit ID out and want to avoid a rebase.

Thanks,

Ingo