media/s2255drv: remove dead code

PATCH New Dan Carpenter 1 participant 1 message May 5, 2010 Media (V4L/DVB)

Share & tools

Dan Carpenter

author

2010-05-05 06:01 UTC #0 lore raw

PATCH 2/2 media/s2255drv: remove dead code

My concern initially was we dereference "dev" in the parameter list to s2255_dev_err() but it turns out that code path is never used. The s2255_stop_readpipe() is only called from one place and "dev" is never null. So this patch just removes the whole condition here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/s2255drv.c +1 -4

index ac9c40c..3c7a79f 100644
@@ -2524,10 +2528,7 @@ static int s2255_stop_acquire(struct s2255_dev *dev, unsigned long chn)
 static void s2255_stop_readpipe(struct s2255_dev *dev)
 {
 	struct s2255_pipeinfo *pipe = &dev->pipe;
-	if (dev == NULL) {
-		s2255_dev_err(&dev->udev->dev, "invalid device\n");
-		return;
-	}
+
 	pipe->state = 0;
 	if (pipe->stream_urb) {
 		/* cancel urb */