isicomm: handle running out of slots
PATCH 1/1 isicomm: handle running out of slots
This patch makes it return -ENODEV if we run out of empty slots in the probe function. It's unlikely to happen, but it makes the static checkers happy.
Signed-off-by Dan Carpenter <[email protected]>
drivers/char/isicom.c +7 -1
@@ -1568,11 +1568,16 @@ static int __devinit isicom_probe(struct pci_dev *pdev,dev_info (&pdev->dev,"ISI PCI Card(Device ID 0x%x)\n" , ent->device);/* allot the first empty slot in the array */ -for (index =0 ; index <BOARD_COUNT ; index++) +for (index =0 ; index <BOARD_COUNT ; index++) {if (isi_card[index].base ==0 ) { board = &isi_card[index];break ; } + } +if (index ==BOARD_COUNT ) { + retval = -ENODEV ; + goto err_disable; + } board->index = index; board->base =pci_resource_start (pdev,3 );
@@ -1619,6 +1624,7 @@ errunrr: errdec: board->base =0 ; card_count--; +err_disable:pci_disable_device (pdev); err:return retval;