Skip to contentSkip to conversation

drm: off by one in drm_edid.c

PATCH In review Dan Carpenter 2 participants 2 messages May 7, 2010 – May 10, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: off by one in drm_edid.c

m == num_est3_modes is one past the end of the est3_modes[].

drivers/gpu/drm/drm_edid.c +1 -1
index 7188674..46447b0 100644
@@ -1383,7 +1383,7 @@ drm_est3_modes(struct drm_connector *connector, struct detailed_timing *timing)
 	for (i = 0; i < 6; i++) {
 		for (j = 7; j > 0; j--) {
 			m = (i * 8) + (7 - j);
-			if (m > num_est3_modes)
+			if (m >= num_est3_modes)
 				break;
 			if (est[i] & (1 << j)) {
 				mode = drm_find_dmt(connector->dev,

------------------------------------------------------------------------------

--

Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Dan Carpenter

m == num_est3_modes is one past the end of the est3_modes[].

drivers/gpu/drm/drm_edid.c +0 -0
index 7188674..46447b0 100644

drivers/gpu/drm/drm_edid.c drm_est3_modes(struct drm_connector *connector, struct detailed_timing *timing) · line 1389

Quoted 8 lines
drivers/gpu/drm/drm_edid.c +1 -1
@@ -1383,7 +1383,7 @@ drm_est3_modes(struct drm_connector *connector, struct detailed_timing *timing)
 	for (i = 0; i < 6; i++) {
 		for (j = 7; j > 0; j--) {
 			m = (i * 8) + (7 - j);
-			if (m > num_est3_modes)
+			if (m >= num_est3_modes)
 				break;
 			if (est[i] & (1 << j)) {
 				mode = drm_find_dmt(connector->dev,

- ajax

------------------------------------------------------------------------------

--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel