Skip to contentSkip to conversation

ath9k/htc_drv_main: null dereference typo

PATCH In review Dan Carpenter 2 participants 2 messages May 8, 2010 – May 10, 2010 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 4/9 ath9k/htc_drv_main: null dereference typo

This is a stray null dereference. We initialize "ista" properly later on.

drivers/net/wireless/ath/ath9k/htc_drv_main.c +1 -1
index f503586..e75db06 100644
@@ -461,7 +461,7 @@ static int ath9k_htc_aggr_oper(struct ath9k_htc_priv *priv,
 	struct ath_common *common = ath9k_hw_common(priv->ah);
 	struct ath9k_htc_target_aggr aggr;
 	struct ieee80211_sta *sta = NULL;
-	struct ath9k_htc_sta *ista = (struct ath9k_htc_sta *) sta->drv_priv;
+	struct ath9k_htc_sta *ista;
 	int ret = 0;
 	u8 cmd_rsp;
 
#1 lore raw

PATCH 4/9 ath9k/htc_drv_main: null dereference typo

Quoted 3 lines · Dan Carpenter

This is a stray null dereference. We initialize "ista" properly later on.

Thanks.

Quoted 13 lines
drivers/net/wireless/ath/ath9k/htc_drv_main.c +1 -1
index f503586..e75db06 100644
@@ -461,7 +461,7 @@ static int ath9k_htc_aggr_oper(struct ath9k_htc_priv *priv,
 	struct ath_common *common = ath9k_hw_common(priv->ah);
 	struct ath9k_htc_target_aggr aggr;
 	struct ieee80211_sta *sta = NULL;
-	struct ath9k_htc_sta *ista = (struct ath9k_htc_sta *) sta->drv_priv;
+	struct ath9k_htc_sta *ista;
 	int ret = 0;
 	u8 cmd_rsp;