Skip to contentSkip to conversation

firewire: cdev: fix fw_cdev_event_bus_reset emission after local config ROM changes

PATCH New Stefan Richter 1 participant 1 message Jul 7, 2010 5 messages not in the archive Firewire

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

PATCH 1/1 firewire: cdev: fix fw_cdev_event_bus_reset emission after local config ROM changes

When a descriptor was added or removed to the local node's config ROM, userspace clients which had a local node's /dev/fw* open did not receive any fw_cdev_event_bus_reset for poll()/read() consumption.

The cause was that the core-device.c facility which re-reads the config ROM of the bus reset initiator node missed to call the fw_device update function. The fw_units are destroyed and newly added, but their parent stays and needs to be updated.

---
 drivers/firewire/core-device.c |    1 +
 1 file changed, 1 insertion(+)
drivers/firewire/core-device.c +1 -0
Index: b/drivers/firewire/core-device.c
===================================================================
@@ -1136,6 +1136,7 @@ static void fw_device_refresh(struct wor
 		goto give_up;
 	}
 
+	fw_device_cdev_update(device);
 	create_units(device);
 
 	/* Userspace may want to re-read attributes. */
Signature · 3 lines
Stefan Richter
-=====-==-=- -=== --===
http://arcgraph.de/sr/