Skip to contentSkip to conversation

acpi: video: fix acpi_backlight=video

PATCH In review [email protected] 2 participants 3 messages May 12, 2010 – May 15, 2010 ACPI

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 acpi: video: fix acpi_backlight=video

From: Kamal Mostafa <[email protected]>

Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO as intended, instead of incorrectly enabling video output switching.

Addresses http://bugs.launchpad.net/bugs/573120

Signed-off-by Kamal Mostafa <[email protected]>
Cc Len Brown <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc Jiri Kosina <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/acpi/video_detect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/video_detect.c renamed from drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video +1 -1
diff -puN drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video drivers/acpi/video_detect.c
@@ -250,7 +250,7 @@ static int __init acpi_backlight(char *s
 				ACPI_VIDEO_BACKLIGHT_FORCE_VENDOR;
 		if (!strcmp("video", str))
 			acpi_video_support |=
-				ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
+				ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
 	}
 	return 1;
 }

_

#2 lore raw
In reply to [email protected]
Quoted 4 lines · On Thursday 13 May 2010 12:33:57 am [email protected] wrote:

From: Kamal Mostafa <[email protected]>

Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO as intended, instead of incorrectly enabling video output switching.

IIRC the only native driver which takes over backlight switching is panasonic, because Len saw 2 brightness steps missing.
This one should have been solved by a "compatibility" patch from Rui and this one could also use video.ko by default.

Still, this one is a safe fix.
Just in case someone wants to avoid the use of this boot param and get things done right by default (and likes to send a patch for it :)).

Thomas

Quoted 32 lines

Addresses http://bugs.launchpad.net/bugs/573120

Signed-off-by Kamal Mostafa <[email protected]>
Cc Len Brown <[email protected]>
Cc Zhang Rui <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc Jiri Kosina <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/acpi/video_detect.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video drivers/acpi/video_detect.c --- a/drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video +++ a/drivers/acpi/video_detect.c

drivers/acpi/video_detect.c renamed from drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video +1 -1
@@ -250,7 +250,7 @@ static int __init acpi_backlight(char *s
 				ACPI_VIDEO_BACKLIGHT_FORCE_VENDOR;
 		if (!strcmp("video", str))
 			acpi_video_support |=
-				ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
+				ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
 	}
 	return 1;
 }

_
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html