GPIO: rdc321x fix inverted gpio data out registers
PATCH 1/1 GPIO: rdc321x fix inverted gpio data out registers
rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.
Signed-off-by Bernhard Loos <[email protected]>
Signed-off-by Florian Fainelli <[email protected]>
---
drivers/gpio/rdc321x-gpio.c +1 -1
@@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip, gpch->data_reg[reg] &= ~(1 << (gpio &0x1f ));pci_write_config_dword (gpch->sb_pdev, - reg ? gpch->reg1_data_base : gpch->reg2_data_base, + reg ? gpch->reg2_data_base : gpch->reg1_data_base, gpch->data_reg[reg]); }
Hi Florian,
Quoted 2 lines · Florian Fainelli
rdc_gpio_set_value_implhas the gpio data registers 1 and 2 inverted, fix this.
Patch applied, thanks a lot.
Cheers,
Samuel.
Quoted 16 lines
Signed-off-by Bernhard Loos <[email protected]>Signed-off-by Florian Fainelli <[email protected]>---
drivers/gpio/rdc321x-gpio.c +1
-1@@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip, gpch->data_reg[reg] &= ~(1 << (gpio &0x1f ));pci_write_config_dword (gpch->sb_pdev, - reg ? gpch->reg1_data_base : gpch->reg2_data_base, + reg ? gpch->reg2_data_base : gpch->reg1_data_base, gpch->data_reg[reg]); }
Signature · 2 lines
Intel Open Source Technology Centre http://oss.intel.com/