Skip to contentSkip to conversation

GPIO: rdc321x fix inverted gpio data out registers

PATCH In review Florian Fainelli 2 participants 2 messages May 16, 2010 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GPIO: rdc321x fix inverted gpio data out registers

rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.

---

drivers/gpio/rdc321x-gpio.c +1 -1
index 22f31dc..2762698 100644
@@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
 		gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
 
 	pci_write_config_dword(gpch->sb_pdev,
-			reg ? gpch->reg1_data_base : gpch->reg2_data_base,
+			reg ? gpch->reg2_data_base : gpch->reg1_data_base,
 			gpch->data_reg[reg]);
 }
 
#1 lore raw

Hi Florian,

Quoted 2 lines · Florian Fainelli

rdc_gpio_set_value_impl has the gpio data registers 1 and 2 inverted, fix this.

Patch applied, thanks a lot.

Cheers,
Samuel.

Quoted 16 lines

---

drivers/gpio/rdc321x-gpio.c +1 -1
index 22f31dc..2762698 100644
@@ -73,7 +73,7 @@ static void rdc_gpio_set_value_impl(struct gpio_chip *chip,
 		gpch->data_reg[reg] &= ~(1 << (gpio & 0x1f));
 
 	pci_write_config_dword(gpch->sb_pdev,
-			reg ? gpch->reg1_data_base : gpch->reg2_data_base,
+			reg ? gpch->reg2_data_base : gpch->reg1_data_base,
 			gpch->data_reg[reg]);
 }
 
Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/