Skip to contentSkip to conversation

selinux: remove all rcu head initializations

PATCH In review Paul E. McKenney 2 participants 5 messages May 18, 2010 – May 19, 2010 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selinux: remove all rcu head initializations

Hello!

Would you guys like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Thanx, Paul

------------------------------------------------------------------------

selinux: remove all rcu head initializations

Remove all rcu head inits. We don't care about the RCU head state before passing it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can keep track of objects on stack.

security/selinux/avc.c +0 -1
index 989fef8..bf4e3bc 100644
@@ -288,7 +288,6 @@ static struct avc_node *avc_alloc_node(void)
 	if (!node)
 		goto out;
 
-	INIT_RCU_HEAD(&node->rhead);
 	INIT_HLIST_NODE(&node->list);
 	avc_cache_stats_incr(allocations);
 
security/selinux/netnode.c +0 -2
index dc92792..65ebfe9 100644
@@ -183,8 +183,6 @@ static void sel_netnode_insert(struct sel_netnode *node)
 		BUG();
 	}
 
-	INIT_RCU_HEAD(&node->rcu);
-
 	/* we need to impose a limit on the growth of the hash table so check
 	 * this bucket to make sure it is within the specified bounds */
 	list_add_rcu(&node->list, &sel_netnode_hash[idx].list);
#1 lore raw
Quoted 5 lines · Paul E. McKenney

Hello!

Would you guys like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Are there any prerequisites for this patch? If not, I'll take it.

Signature · 7 lines
James Morris
<[email protected]>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#2 lore raw
Quoted 9 lines · James Morris
Quoted 5 lines · Paul E. McKenney

Hello!

Would you guys like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Are there any prerequisites for this patch? If not, I'll take it.

There are no prerequisites. Please let me know when you have taken it, and I will happily remove it from my tree. ;-)

Thanx, Paul

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.

#3 lore raw
In reply to Paul E. McKenney
Quoted 6 lines · Paul E. McKenney

Hello!

Would you guys like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-queue

Signature · 7 lines
James Morris
<[email protected]>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.
#4 lore raw
Quoted 11 lines · James Morris
Quoted 6 lines · Paul E. McKenney

Hello!

Would you guys like to carry this patch, or should I push it up -tip? If I don't hear otherwise from you, I will push it up -tip. The INIT_RCU_HEAD() primitive is going away in favor of debugobjects.

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-queue

Thank you, I have removed it from my tree.

Thanx, Paul

--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.