Skip to contentSkip to conversation

sh_eth: Fix memleak in sh_mdio_release

PATCH Applied Denis Kirjanov 3 participants 3 messages May 20, 2010 – May 21, 2010

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Denis Kirjanov

author
#0 lore raw

PATCH 1/1 sh_eth: Fix memleak in sh_mdio_release

Allocated memory for IRQs should be freed when releasing the mii_bus

Signed-off-by Denis Kirjanov <[email protected]>

---

drivers/net/sh_eth.c | 3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/sh_eth.c +3 -0
index 586ed09..501a55f 100644
@@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
 	/* remove mdio bus info from net_device */
 	dev_set_drvdata(&ndev->dev, NULL);
 
+	/* free interrupts memory */
+	kfree(bus->irq);
+
 	/* free bitbang info */
 	free_mdio_bitbang(bus);
Acked-by on v1 1/1
#1 lore raw

Hi, Denis.

2010/5/20 Denis Kirjanov <[email protected]>:

Quoted 14 lines

Allocated memory for IRQs should be freed when releasing the mii_bus

Signed-off-by Denis Kirjanov <[email protected]>

---

drivers/net/sh_eth.c |    3 +++

 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/net/sh_eth.c +0 -0
index 586ed09..501a55f 100644

drivers/net/sh_eth.c static int sh_mdio_release(struct net_device *ndev) · line 1302

Quoted 9 lines
drivers/net/sh_eth.c +3 -0
@@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
        /* remove mdio bus info from net_device */
        dev_set_drvdata(&ndev->dev, NULL);
 
+       /* free interrupts memory */
+       kfree(bus->irq);
+
        /* free bitbang info */
        free_mdio_bitbang(bus);
Acked-by Nobuhiro Iwamatsu <[email protected]>

Thanks!

Best regards,
Nobuhiro