Skip to contentSkip to conversation

mark down nodes properly

PATCH Applied Pete Zaitcev 2 participants 2 messages May 22, 2010 – May 25, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 mark down nodes properly

A simple assignment was forgotten, so tabled was expending a bit of extra effort trying to contact nodes that are down.

Also, change the log level to match the line above.

---
 server/server.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

commit 422fbb466a3e8e1599894069dff3dc50e189f7bd

Author: Pete Zaitcev <[email protected]>
Date:   Fri May 21 19:50:55 2010 -0600

Actually mark down nodes as down.

server/server.c +3 -2
index 1c7114a..4e8dba3 100644
@@ -1499,9 +1499,10 @@ int stor_update_cb(void)
 			stn->up = true;
 			stn->last_up = time(NULL);
 		} else {
-			if (stn->last_up != 0 &&
+			if (stn->up &&
 			    time(NULL) >= stn->last_up + CHUNK_REBOOT_TIME) {
-				applog(LOG_INFO, " NID %u went down", stn->id);
+				applog(LOG_DEBUG, " NID %u went down", stn->id);
+				stn->up = false;
 			}
 		}
 	}
Applied
#1 lore raw
Quoted 6 lines · Pete Zaitcev

A simple assignment was forgotten, so tabled was expending a bit of extra effort trying to contact nodes that are down.

Also, change the log level to match the line above.

applied