Skip to contentSkip to conversation

: Fix userspace warnings in elfcore.h

PATCH In review Prarit Bhargava 2 participants 2 messages May 24, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : Fix userspace warnings in elfcore.h

Fixes compile warning:

/home/rhel6/usr/include/linux/elfcore.h:104: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:105: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:108: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:110: userspace cannot call function or variable defined in the kernel

include/linux/elfcore.h +1 -2
index e687bc3..26f7486 100644
@@ -150,8 +150,6 @@ static inline int elf_core_copy_task_xfpregs(struct task_struct *t, elf_fpxregse
 }
 #endif
 
-#endif /* __KERNEL__ */
-
 /*
  * These functions parameterize elf_core_dump in fs/binfmt_elf.c to write out
  * extra segments containing the gate DSO contents.  Dumping its
@@ -167,5 +165,6 @@ elf_core_write_extra_phdrs(struct file *file, loff_t offset, size_t *size,
 extern int
 elf_core_write_extra_data(struct file *file, size_t *size, unsigned long limit);
 extern size_t elf_core_extra_data_size(void);
+#endif /* __KERNEL__ */
 
 #endif /* _LINUX_ELFCORE_H */
#1 lore raw
Quoted 8 lines · On Mon, 24 May 2010 09:54:44 -0400 Prarit Bhargava wrote:

Fixes compile warning:

/home/rhel6/usr/include/linux/elfcore.h:104: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:105: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:108: userspace cannot call function or variable defined in the kernel /home/rhel6/usr/include/linux/elfcore.h:110: userspace cannot call function or variable defined in the kernel

Patch was merged last Saturyday:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=2faa4cf76e7d229016240b79b50a43d81f458323

Quoted 14 lines
include/linux/elfcore.h +0 -2
index e687bc3..26f7486 100644
@@ -150,8 +150,6 @@ static inline int elf_core_copy_task_xfpregs(struct task_struct *t, elf_fpxregse
 }
 #endif
 
-#endif /* __KERNEL__ */
-
 /*
  * These functions parameterize elf_core_dump in fs/binfmt_elf.c to write out
  * extra segments containing the gate DSO contents.  Dumping its

include/linux/elfcore.h elf_core_write_extra_phdrs(struct file *file, loff_t offset, size_t *size,

Quoted 7 lines
include/linux/elfcore.h +1 -1
@@ -167,5 +165,6 @@ elf_core_write_extra_phdrs(struct file *file, loff_t offset, size_t *size,
 extern int
 elf_core_write_extra_data(struct file *file, size_t *size, unsigned long limit);
 extern size_t elf_core_extra_data_size(void);
+#endif /* __KERNEL__ */
 
 #endif /* _LINUX_ELFCORE_H */
--

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***