Skip to contentSkip to conversation

scsi: fix bnx2i build errors

PATCH In review [email protected] 1 participant 1 message May 24, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 25/26 scsi: fix bnx2i build errors

From: Randy Dunlap <[email protected]>

bnx2i should depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET.

Also move the dependencies together.

The "depends" change fixes multiple build errors when CONFIG_NET is not enabled:
ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!

Cc Anil Veerabhadrappa <[email protected]>
Cc James Bottomley <[email protected]>

---

 drivers/scsi/bnx2i/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/scsi/bnx2i/Kconfig renamed from drivers/scsi/bnx2i/Kconfig~scsi-fix-bnx2i-build-errors +2 -1
diff -puN drivers/scsi/bnx2i/Kconfig~scsi-fix-bnx2i-build-errors drivers/scsi/bnx2i/Kconfig
@@ -1,10 +1,11 @@
 config SCSI_BNX2_ISCSI
 	tristate "Broadcom NetXtreme II iSCSI support"
+	depends on NET
+	depends on PCI
 	select SCSI_ISCSI_ATTRS
 	select NETDEVICES
 	select NETDEV_1000
 	select CNIC
-	depends on PCI
 	---help---
 	This driver supports iSCSI offload for the Broadcom NetXtreme II
 	devices.

_