Skip to contentSkip to conversation

padata: add parenthesis in MAX_SEQ_NR macro

PATCH In review Dan Carpenter 3 participants 3 messages May 25, 2010 – Jun 3, 2010

Subsystems (2)
Kernel janitors Padata parallel execution mechanism
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 padata: add parenthesis in MAX_SEQ_NR macro

MAX_SEQ_NR is used in padata_alloc_pd() like this:

        pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;

It needs parenthesis or the divide by num_cpus takes precedence over the subtraction.

Signed-off-by Dan Carpenter <[email protected]>

---
Found by a static checker. I don't really know this code.

kernel/padata.c +1 -1
index b1c9857..ff8de1b 100644
@@ -28,7 +28,7 @@
 #include <linux/slab.h>
 #include <linux/rcupdate.h>
 
-#define MAX_SEQ_NR INT_MAX - NR_CPUS
+#define MAX_SEQ_NR (INT_MAX - NR_CPUS)
 #define MAX_OBJ_NUM 1000
 
 static int padata_index_to_cpu(struct parallel_data *pd, int cpu_index)