Skip to contentSkip to conversation

Deadlock/crash in 2.6.32.12 when copying large files

DISCUSSION Leszek Urbanski 2 participants 2 messages May 25, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi,

I've hit https://bugzilla.kernel.org/show_bug.cgi?id=15578 again with 2.6.32.12 on amd64.

I can reproduce it every time when copying large (>2G) files over NFS. The call trace is at https://bugzilla.kernel.org/attachment.cgi?id=26519

Needless to say it results in a system crash (kswapd deadlock, network stack failure because of memory allocation failure for SKBs, etc.).

Trond Myklebust closed this bug a while ago, but apparently it's not completely fixed and needs to be re-opened.

Signature · 1 line
Leszek Urbanski
#1 lore raw

Hi,

Quoted 11 lines · Leszek Urbanski

I've hit https://bugzilla.kernel.org/show_bug.cgi?id=15578 again with 2.6.32.12 on amd64.

I can reproduce it every time when copying large (>2G) files over NFS. The call trace is at https://bugzilla.kernel.org/attachment.cgi?id=26519

Needless to say it results in a system crash (kswapd deadlock, network stack failure because of memory allocation failure for SKBs, etc.).

Trond Myklebust closed this bug a while ago, but apparently it's not completely fixed and needs to be re-opened.

You could try this workaround, it works for me. Cherry picked from 2.6.34 vanila.

commit 3d7b08945e54a3a5358d5890240619a013cb7388

Author: Trond Myklebust <[email protected]>
Date:   Thu Apr 22 15:35:55 2010 -0400

SUNRPC: Fix a bug in rpcauth_prune_expired

Don't want to evict a credential if cred->cr_expire == jiffies, since that means that it was just placed on the cred_unused list. We therefore need to use time_in_range() rather than time_in_range_open().

net/sunrpc/auth.c +0 -0
index f394fc1..95afe79 100644
@@ -237,7 +237,7 @@ rpcauth_prune_expired(struct list_head *free, int

nr_to_scan)

        list_for_each_entry_safe(cred, next, &cred_unused, cr_lru) {

                /* Enforce a 60 second garbage collection moratorium */
-               if (time_in_range_open(cred->cr_expire, expired, jiffies) &&
+               if (time_in_range(cred->cr_expire, expired, jiffies) &&
                    test_bit(RPCAUTH_CRED_HASHED, &cred->cr_flags) != 0)
                        continue;
Signature · 1 line
Lukáš Hejtmánek