Skip to contentSkip to conversation

rds/iw_rdma: spin_lock_irq() is not nestable

PATCH In review Dan Carpenter 1 participant 1 message May 27, 2010

Subsystems (4)
Networking Network drivers Kernel janitors RDS - reliable datagram sockets
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/3 rds/iw_rdma: spin_lock_irq() is not nestable

The IRQs are already disabled here so we don't need to disable them again.

Signed-off-by Dan Carpenter <[email protected]>
net/rds/iw_rdma.c +2 -2
index 7365fa2..48d5073 100644
@@ -213,9 +213,9 @@ void rds_iw_add_conn(struct rds_iw_device *rds_iwdev, struct rds_connection *con
 	BUG_ON(list_empty(&ic->iw_node));
 	list_del(&ic->iw_node);
 
-	spin_lock_irq(&rds_iwdev->spinlock);
+	spin_lock(&rds_iwdev->spinlock);
 	list_add_tail(&ic->iw_node, &rds_iwdev->conn_list);
-	spin_unlock_irq(&rds_iwdev->spinlock);
+	spin_unlock(&rds_iwdev->spinlock);
 	spin_unlock_irq(&iw_nodev_conns_lock);
 
 	ic->rds_iwdev = rds_iwdev;