streamline_config.pl: use references rather than copied data structures

IMHO there's no need for a copy-by-value

Signed-off-by Toralf Foerster <[email protected]>

---
 scripts/kconfig/streamline_config.pl |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

scripts/kconfig/streamline_config.pl +3 -3

index afbd54a..574e68f 100644
@@ -406,14 +406,14 @@ close(CIN);
 loop:
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       my @arr = @{$objects{$module}};
-       foreach my $conf (@arr) {
+       my $arr = $objects{$module};
+       foreach my $conf (@{$arr}) {
            if (defined($setconfigs{$conf})) {
                next loop;
            }
        }
        print STDERR "module $module did not have configs";
-       foreach my $conf (@arr) {
+       foreach my $conf (@{$arr}) {
            print STDERR " " , $conf;
        }
        print STDERR "\n";

Signature · 1 line

1.6.4.4

Quoted 1 line

IMHO there's no need for a copy-by-value

Hi Toralf,

I'm sorry but "Your Humble Opinion" is not rational to make changes.

A change to the code must have a reason other than opinion. You must be able to show that there is actual benefit for a change, or at least explain it.

Every time a change is made, there is potential for a new bug to be introduced (especially in Perl). So, unless there's actual need for a change, don't make one.

This is not performance critical code. If you are fixing a bug, or adding a feature, then sure. But I really don't want changes that do nothing but skin the cat a different way.

Thanks,

-- Steve

Steven Rostedt wrote at 15:07:29

Quoted 1 line · Toralf Förster

Understood and accepted.

What's about the following 2 snippets (a trivial typo and an attempt to prevent a possible trap) ? :

scripts/kconfig/streamline_config.pl +1 -1

index afbd54a..3f54911 100644
@@ -242,7 +242,7 @@ foreach my $makefile (@makefiles) {
            foreach my $obj (split /\s+/,$objs) {
                $obj =~ s/-/_/g;
                if ($obj =~ /(.*)\.o$/) {
-                   # Objects may bes enabled by more than one config.
+                   # Objects may be enabled by more than one config.
                    # Store configs in an array.
                    my @arr;
 

scripts/kconfig/streamline_config.pl +1 -1

index afbd54a..9726946 100644
@@ -307,7 +307,7 @@ close (LIN);
 my %configs;
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       @arr = @{$objects{$module}};
+       my @arr = @{$objects{$module}};
        foreach my $conf (@arr) {
            $configs{$conf} = $module;
        }

Understood and accepted.

What's about the following 2 snippets (a trivial typo and an attempt to prevent a possible trap) ? :

scripts/kconfig/streamline_config.pl +1 -1

index afbd54a..3f54911 100644
@@ -242,7 +242,7 @@ foreach my $makefile (@makefiles) {
            foreach my $obj (split /\s+/,$objs) {
                $obj =~ s/-/_/g;
                if ($obj =~ /(.*)\.o$/) {
-                   # Objects may bes enabled by more than one config.
+                   # Objects may be enabled by more than one config.
                    # Store configs in an array.
                    my @arr;
 

scripts/kconfig/streamline_config.pl +1 -1

index afbd54a..9726946 100644
@@ -307,7 +307,7 @@ close (LIN);
 my %configs;
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       @arr = @{$objects{$module}};
+       my @arr = @{$objects{$module}};
        foreach my $conf (@arr) {
            $configs{$conf} = $module;
        }