ALSA, hda: Add support for Lenovo ThinkPad Edge 13 in conexant codec
At Thu, 27 May 2010 18:06:56 +0200,
Quoted 9 lines · Andreas Herrmann
From: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 I had the problem that speakers played sound although headphones were plugged.
Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to add this quirk. (Using other models, like ideabad did not fix it.)
Quoted 8 lines
Signed-off-by Andreas Herrmann <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)I don't know whether adding this quirk is the right/complete solution to support sound on Thinkpad Edge. But at least it solves this annoying problem.
Well, Jerone Young already sent a quirk patch but he took model=ideapd. Could you guys check which one is really better?
thanks,
Takashi
Quoted 23 lines
Please apply.
Thanks,
Andreas
sound/pci/hda/patch_conexant.c +1
-0@@ -2848,6 +2848,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {SND_PCI_QUIRK (0x1179 ,0xff50 ,"Toshiba Satellite P500-PSPGSC-01800T" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x1179 ,0xffe0 ,"Toshiba Satellite Pro T130-15F" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x17aa ,0x21b2 ,"Thinkpad X100e" ,CXT5066_IDEAPAD ), +SND_PCI_QUIRK (0x17aa ,0x21b3 ,"Thnkpad Edge 13" ,CXT5066_OLPC_XO_1_5 ), SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD), {} };Signature · 1 line
1.6.4.4
@Andreas
can you grab Alsa git tree and install it on the system you are using.
It has a patch already taking care of the issue.
The issue Takashi is most likely folks using the older kernel version. model=ideapad was just recently introduced so they where unable to try that out. But olpc-xo-1_5 has been there for a while. Though for Lenovo products model=ideapad is much better.
Thanks,
Jerone
Quoted 52 lines · Takashi Iwai
At Thu, 27 May 2010 18:06:56 +0200,
Quoted 9 lines · Andreas Herrmann
From: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 I had the problem that speakers played sound although headphones were plugged.
Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to add this quirk. (Using other models, like ideabad did not fix it.)
Quoted 8 lines
Signed-off-by Andreas Herrmann <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)I don't know whether adding this quirk is the right/complete solution to support sound on Thinkpad Edge. But at least it solves this annoying problem.
Well, Jerone Young already sent a quirk patch but he took model=ideapd. Could you guys check which one is really better?
thanks,
Takashi
Quoted 23 lines
Please apply.
Thanks,
Andreas
sound/pci/hda/patch_conexant.c +1
-0@@ -2848,6 +2848,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {SND_PCI_QUIRK (0x1179 ,0xff50 ,"Toshiba Satellite P500-PSPGSC-01800T" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x1179 ,0xffe0 ,"Toshiba Satellite Pro T130-15F" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x17aa ,0x21b2 ,"Thinkpad X100e" ,CXT5066_IDEAPAD ), +SND_PCI_QUIRK (0x17aa ,0x21b3 ,"Thnkpad Edge 13" ,CXT5066_OLPC_XO_1_5 ), SND_PCI_QUIRK(0x17aa, 0x3a0d, "ideapad", CXT5066_IDEAPAD), {} };Signature · 1 line
1.6.4.4
Quoted 16 lines · Takashi Iwai
At Thu, 27 May 2010 18:06:56 +0200,
Quoted 14 lines · Andreas Herrmann
From: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 I had the problem that speakers played sound although headphones were plugged.
Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to add this quirk. (Using other models, like ideabad did not fix it.)
Signed-off-by Andreas Herrmann <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 6 lines
Quoted 3 lines
I don't know whether adding this quirk is the right/complete solution to support sound on Thinkpad Edge. But at least it solves this annoying problem.
Well, Jerone Young already sent a quirk patch but he took model=ideapd. Could you guys check which one is really better?
Hi Jerone,
there are two different models of Thinkpad Edge (one with Intel CPU/chipset, one with AMD CPU/chipset). I tested on the AMD version but from
https://bugs.launchpad.net/ubuntu/+source/linux-backports-modules-2.6.32/+bug/549289
it seems that using model=olpc-xo-1_5 works for both versions of that Thinkpad.
I also tried ideapad -- because looking at the quirk table for cxt5066 there is this entry
SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),
and adding
SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge", CXT5066_IDEAPAD),
seems to be conclusive.
But as I said that did not solve the problem of speakers still playing audio if headphones are plugged in for me. Have you explicitely tested this? Maybe I have to retest with some newer code from the alsa tree?
Regards,
Andreas
Are you sure? The pci id I have is for 0x21b4 based on information from that bug. What you point out is 0x21b3. Please retest with
SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD)
Can you post lspci -vvnn output for your Thinkpad Edge?
Here is the patch I sent:
pci/hda/patch_conexant.c +1 -0
@@ -2975,6 +2975,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {SND_PCI_QUIRK (0x1179 ,0xff50 ,"Toshiba Satellite P500-PSPGSC-01800T" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x1179 ,0xffe0 ,"Toshiba Satellite Pro T130-15F" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x17aa ,0x21b2 ,"Thinkpad X100e" ,CXT5066_IDEAPAD ), +SND_PCI_QUIRK (0x17aa ,0x21b4 ,"Thinkpad Edge" ,CXT5066_IDEAPAD ),SND_PCI_QUIRK (0x17aa ,0x3a0d ,"ideapad" ,CXT5066_IDEAPAD ), SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD),
Thanks,
Jerone
Quoted 51 lines · Andreas Herrmann
Quoted 16 lines · Takashi Iwai
At Thu, 27 May 2010 18:06:56 +0200,
Quoted 14 lines · Andreas Herrmann
From: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 I had the problem that speakers played sound although headphones were plugged.
Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to add this quirk. (Using other models, like ideabad did not fix it.)
Signed-off-by Andreas Herrmann <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)Quoted 6 lines
Quoted 3 lines
I don't know whether adding this quirk is the right/complete solution to support sound on Thinkpad Edge. But at least it solves this annoying problem.
Well, Jerone Young already sent a quirk patch but he took model=ideapd. Could you guys check which one is really better?
Hi Jerone,
there are two different models of Thinkpad Edge (one with Intel CPU/chipset, one with AMD CPU/chipset). I tested on the AMD version but from
https://bugs.launchpad.net/ubuntu/+source/linux-backports-modules-2.6.32/+bug/549289
it seems that using model=olpc-xo-1_5 works for both versions of that Thinkpad.
I also tried ideapad -- because looking at the quirk table for cxt5066 there is this entry
SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),and adding
SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge", CXT5066_IDEAPAD),seems to be conclusive.
But as I said that did not solve the problem of speakers still playing audio if headphones are plugged in for me. Have you explicitely tested this? Maybe I have to retest with some newer code from the alsa tree?
Regards,
Andreas
Quoted 6 lines · Jerone Young
Are you sure? The pci id I have is for
0x21b4based on information from that bug. What you point out is0x21b3. Please retest with
SND_PCI_QUIRK(0x17aa, 0x21b4, "Thinkpad Edge", CXT5066_IDEAPAD)Can you post lspci -vvnn output for your Thinkpad Edge?
The PCI audio device is:
00:14.2 Audio device [0403]: ATI Technologies Inc SBx00 Azalia (Intel HDA) [1002:4383]
Subsystem: Lenovo Device [17aa:21b3]
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=slow >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 64, Cache Line Size: 32 bytes
Interrupt: pin ? routed to IRQ 16
Region 0: Memory at d0600000 (64-bit, non-prefetchable) [size=16K]
Capabilities: <access denied>
Kernel driver in use: HDA Intel
Kernel modules: snd-hda-intel
So maybe yours is the Intel version of Thinkpad Edge 13?
What does dmidecode say for your system? Here is my information:
Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer: LENOVO
Product Name: 01972NG
Version: ThinkPad Edge 13"IAL#
Other types of that notebook family are 0196 and 0492 each having a huge bunch of differnet models (2NG in my case).
However I try to retest with latest alsa tree (using model=ideapad) maybe that changes something.
Andreas
PATCH 1/1 ALSA, hda: Add support for another Lenovo ThinkPad Edge in conexant codec
In reply to a message not in the archiveFrom: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 "01972NG" I had the problem that speakers played sound although headphones were plugged in. Using model=ideapad with latest alsa-git kernel fixed this. So adding this quirk to use ideapad for another Thinkpad Edge variant seems sensible.
--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Patch is against today's sound-2.6 git tree.
Please apply.
Thanks,
Andreas
sound/pci/hda/patch_conexant.c +1 -0
@@ -2975,6 +2975,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {SND_PCI_QUIRK (0x1179 ,0xff50 ,"Toshiba Satellite P500-PSPGSC-01800T" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x1179 ,0xffe0 ,"Toshiba Satellite Pro T130-15F" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x17aa ,0x21b2 ,"Thinkpad X100e" ,CXT5066_IDEAPAD ), +SND_PCI_QUIRK (0x17aa ,0x21b3 ,"Thinkpad Edge 13 (197)" ,CXT5066_IDEAPAD ),SND_PCI_QUIRK (0x17aa ,0x21b4 ,"Thinkpad Edge" ,CXT5066_IDEAPAD ),SND_PCI_QUIRK (0x17aa ,0x3a0d ,"ideapad" ,CXT5066_IDEAPAD ), SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD),
Signature · 1 line
1.7.1
Re: [PATCH] ALSA, hda: Add support for another Lenovo ThinkPad Edge in conexant codec
At Fri, 28 May 2010 09:57:12 +0200,
Quoted 8 lines · Andreas Herrmann
From: Andreas Herrmann <[email protected]>
On a Thinkpad Edge 13 "01972NG" I had the problem that speakers played sound although headphones were plugged in. Using model=ideapad with latest alsa-git kernel fixed this. So adding this quirk to use ideapad for another Thinkpad Edge variant seems sensible.
Quoted 8 lines
Cc Jerone Young <[email protected]>Signed-off-by Andreas Herrmann <[email protected]>--- sound/pci/hda/patch_conexant.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)Patch is against today's sound-2.6 git tree.
Please apply.
Thanks for a quick check. Applied now.
Takashi
Quoted 20 lines
Thanks,
Andreassound/pci/hda/patch_conexant.c +1
-0@@ -2975,6 +2975,7 @@ static struct snd_pci_quirk cxt5066_cfg_tbl[] = {SND_PCI_QUIRK (0x1179 ,0xff50 ,"Toshiba Satellite P500-PSPGSC-01800T" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x1179 ,0xffe0 ,"Toshiba Satellite Pro T130-15F" ,CXT5066_OLPC_XO_1_5 ),SND_PCI_QUIRK (0x17aa ,0x21b2 ,"Thinkpad X100e" ,CXT5066_IDEAPAD ), +SND_PCI_QUIRK (0x17aa ,0x21b3 ,"Thinkpad Edge 13 (197)" ,CXT5066_IDEAPAD ),SND_PCI_QUIRK (0x17aa ,0x21b4 ,"Thinkpad Edge" ,CXT5066_IDEAPAD ),SND_PCI_QUIRK (0x17aa ,0x3a0d ,"ideapad" ,CXT5066_IDEAPAD ), SND_PCI_QUIRK(0x17aa, 0x215e, "Lenovo Thinkpad", CXT5066_THINKPAD),Signature · 1 line
1.7.1