Skip to contentSkip to conversation

streamline_config.pl: make a variable local

PATCH In review Toralf Foerster 2 participants 2 messages May 28, 2010

Subsystems (2)
Kbuild Kconfig
lore
Share & tools
lore

Toralf Foerster

author
#0 lore raw

PATCH 1/1 streamline_config.pl: make a variable local

to prevent a possible pitfall

Signed-off-by Toralf Foerster <[email protected]>
---
 scripts/kconfig/streamline_config.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/kconfig/streamline_config.pl +1 -1
index afbd54a..9726946 100644
@@ -307,7 +307,7 @@ close (LIN);
 my %configs;
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       @arr = @{$objects{$module}};
+       my @arr = @{$objects{$module}};
        foreach my $conf (@arr) {
            $configs{$conf} = $module;
        }
Signature · 8 lines
1.6.4.4


-- 
MfG/Sincerely
Toralf Foerster

pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
#1 lore raw
Quoted 12 lines · Toralf Foerster

to prevent a possible pitfall

Signed-off-by Toralf Foerster <[email protected]>
---
 scripts/kconfig/streamline_config.pl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/kconfig/streamline_config.pl +0 -0
index afbd54a..9726946 100644

scripts/kconfig/streamline_config.pl close (LIN); · line 310

Quoted 5 lines
scripts/kconfig/streamline_config.pl +1 -1
@@ -307,7 +307,7 @@ close (LIN);
 my %configs;
 foreach my $module (keys(%modules)) {
     if (defined($objects{$module})) {
-       @arr = @{$objects{$module}};
+       my @arr = @{$objects{$module}};

Either your mail client, or the method you use to get these into your mail is causing whitespace issues. There are tabs here that your patch has converted into spaces, causing the patch to fail to apply.

I've fixed it up, but please fix this before sending more patches.

-- Steve

Quoted 7 lines
scripts/kconfig/streamline_config.pl +0 -0
        foreach my $conf (@arr) {
            $configs{$conf} = $module;
        }
Signature · 1 line
1.6.4.4