sfi: returning freed pointer

PATCH New Dan Carpenter 1 participant 1 message May 28, 2010 Kernel janitors

Share & tools

Dan Carpenter

author

2010-05-28 10:33 UTC #0 lore raw

PATCH 1/1 sfi: returning freed pointer

We never actually use the return value of sfi_sysfs_install_table() but it still seems wrong to return a freed pointer.

Signed-off-by Dan Carpenter <[email protected]>

drivers/sfi/sfi_core.c +3 -1

index 0051959..ceba593 100644
@@ -441,8 +441,10 @@ struct sfi_table_attr __init *sfi_sysfs_install_table(u64 pa)
 
 	ret = sysfs_create_bin_file(tables_kobj,
 				  &tbl_attr->attr);
-	if (ret)
+	if (ret) {
 		kfree(tbl_attr);
+		tbl_attr = NULL;
+	}
 
 	sfi_unmap_table(th);
 	return tbl_attr;