btrfs: unwind after btrfs_start_transaction() errors

PATCH In review Dan Carpenter 1 participant 1 message May 29, 2010

Subsystems (2)

Kernel janitors Btrfs file system

lore

Share & tools

lore

Dan Carpenter

author

2010-05-29 09:46 UTC #0 lore raw

PATCH 7/11 btrfs: unwind after btrfs_start_transaction() errors

This was added by a22285a6a3: "Btrfs: Integrate metadata reservation with start_transaction". If we goto out here then we skip all the unwinding and there are locks still held etc.

Signed-off-by Dan Carpenter <[email protected]>

fs/btrfs/ioctl.c +1 -1

index 4cdb98c..9f9a1d9 100644
@@ -1280,7 +1280,7 @@ static noinline int btrfs_ioctl_snap_destroy(struct file *file,
 	trans = btrfs_start_transaction(root, 0);
 	if (IS_ERR(trans)) {
 		err = PTR_ERR(trans);
-		goto out;
+		goto out_up_write;
 	}
 	trans->block_rsv = &root->fs_info->global_block_rsv;