Skip to contentSkip to conversation

question about gss_verify_mic_v2()

DISCUSSION Dan Carpenter 2 participants 2 messages May 31, 2010 – Jun 1, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Kevin,

Are we planning to add the sequencing checks later or can I remove the comment?

net/sunrpc/auth_gss/gss_krb5_unseal.c +202 gss_verify_mic_v2()
warn: unused return: seqnum = __be64_to_cpup()

   200          /* do sequencing checks */
   201
   202          seqnum = be64_to_cpup((__be64 *)ptr + 8);
   203
   204          return GSS_S_COMPLETE;
   205  }

regards,
dan carpenter

#1 lore raw

I think it would be good to add sequence checks, but I don't have the cycles to work on it.

Quoted 19 lines · Dan Carpenter

Hi Kevin,

Are we planning to add the sequencing checks later or can I remove the comment?

net/sunrpc/auth_gss/gss_krb5_unseal.c +202 gss_verify_mic_v2()
        warn: unused return: seqnum = __be64_to_cpup()

  200          /* do sequencing checks */
  201
  202          seqnum = be64_to_cpup((__be64 *)ptr + 8); 203
  204          return GSS_S_COMPLETE;
  205  }

regards,
dan carpenter