Skip to contentSkip to conversation

mtd: return success on blktrans_ioctl()

PATCH Applied Dan Carpenter 2 participants 2 messages May 31, 2010 – Jun 13, 2010

Subsystems (2)
Kernel janitors Memory technology devices (MTD)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mtd: return success on blktrans_ioctl()

There was a break missing so we returned -ENOTTY on success instead of zero. This was introduced by 048d8719956: "mtd: blktrans: Hotplug fixes"

Signed-off-by Dan Carpenter <[email protected]>
drivers/mtd/mtd_blkdevs.c +1 -0
index 03e19c1..a6bb586 100644
@@ -245,6 +245,7 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode,
 	switch (cmd) {
 	case BLKFLSBUF:
 		ret = dev->tr->flush ? dev->tr->flush(dev) : 0;
+		break;
 	default:
 		ret = -ENOTTY;
 	}
Applied
#1 lore raw
Quoted 4 lines · Dan Carpenter

There was a break missing so we returned -ENOTTY on success instead of zero. This was introduced by 048d8719956: "mtd: blktrans: Hotplug fixes"

Signed-off-by Dan Carpenter <[email protected]>

Pushed to l2-mtd-2.6.git, thanks.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)