Skip to contentSkip to conversation

regression 2.6.35-rc1+ hda realtek missing beep 10ec0883

PATCH New David Fries 1 participant 1 message Jun 2, 2010 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regression 2.6.35-rc1+ hda realtek missing beep 10ec0883

From: David Fries <[email protected]>

The PC-Spekaer Beep control worked in 2.6.34, but not 2.6.35-rc1, this is the patch that modified that behavior.
"ALSA: hda - Add parse customize define function for Realtek codecs" regression in commit da00c24493bf6ae3772dfe7343dca033ebc75955.

Debug output (after this patch),
HDA Intel 0000:00:14.2: PCI INT A -> GSI 16 (level, low) -> IRQ 16
SKU: Nid=0x0 sku_cfg=0x0000140d
SKU: port_connectivity=0x0
SKU: enable_pcbeep=0x0
SKU: check_sum=0x00000000
SKU: customization=0x00000000
SKU: external_amp=0x1
SKU: platform_type=0x1
SKU: swap=0x0
SKU: override=0x1
hda_codec: ALC883: BIOS auto-probing.
autoconfig: line_outs=1 (0x14/0x0/0x0/0x0/0x0)
speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
hp_outs=0 (0x0/0x0/0x0/0x0/0x0)
mono: mono_out=0x0
dig-out=0x1e/0x0
inputs: mic=0x18, fmic=0x0, line=0x1a, fline=0x0, cd=0x1c, aux=0x0
realtek: Enabling init ASM_ID=0x140d CODEC_ID=10ec0883
input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:14.2/input/input16

Cc Kailang Yang <[email protected]>
Cc Takashi Iwai <[email protected]>

---
My patch restores both the Beep volume and mute. I'll let someone else determine if this is the correct solution or not.

 sound/pci/hda/patch_realtek.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/hda/patch_realtek.c +1 -1
index 17d4548..c31c8b9 100644
@@ -10611,7 +10611,7 @@ static int patch_alc882(struct hda_codec *codec)
 
 	set_capture_mixer(codec);
 
-	if (spec->cdefine.enable_pcbeep)
+	if (spec->cdefine.enable_pcbeep || codec->vendor_id == 0x10ec0883)
 		set_beep_amp(spec, 0x0b, 0x05, HDA_INPUT);
 
 	if (board_config == ALC882_AUTO)
Signature · 1 line
1.7.1