Skip to contentSkip to conversation

modules: remove -w option (ie. !O_NONBLOCK)?

DISCUSSION Rusty Russell 2 participants 2 messages Jun 3, 2010

lore
Share & tools
lore
#0 lore raw

Hi Jon,

Since waiting module removal was never implemented in modprobe, I wonder
if we should simply get rid of it? (It's implemented in rmmod only). Unused code is buggy code, and there doesn't seem to be a demand for removing modules "at some time in the future".

Thoughts?
Rusty.

#1 lore raw
Quoted 6 lines · Rusty Russell

Since waiting module removal was never implemented in modprobe, I wonder
if we should simply get rid of it? (It's implemented in rmmod only). Unused code is buggy code, and there doesn't seem to be a demand for removing modules "at some time in the future".

Thoughts?

I'll think some more after coffee this morning but my first instinct is "sure, few people care about module removal anyway any more" :)

Jon.