Staging: rc2860: return -EFAULT on copy_to_user errors

PATCH New Dan Carpenter 1 participant 1 message Jun 4, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-06-04 10:39 UTC #0 lore raw

PATCH 1/1 Staging: rc2860: return -EFAULT on copy_to_user errors

copy_to_user() returns the number of bytes remaining but we want to return a negative error code. This is in the ioctl handler and the error code gets passed to userspace.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/rt2860/sta_ioctl.c +2 -0

index 112da7a..6b8268d 100644
@@ -2522,6 +2522,8 @@ int rt28xx_sta_ioctl(IN struct net_device *net_dev,
 			Status  			    copy_to_user(erq->pointer, pAd->nickname,
 					 erq->length);
+			if (Status)
+				Status = -EFAULT;
 			break;
 		}
 	case SIOCGIWRATE:	/*get default bit rate (bps) */