V4L/DVB: cx23885: reversed condition in dvb_register()

PATCH New Dan Carpenter 1 participant 1 message Jun 5, 2010 Media (V4L/DVB)

Share & tools

Dan Carpenter

author

2010-06-05 12:06 UTC #0 lore raw

PATCH 1/1 V4L/DVB: cx23885: reversed condition in dvb_register()

videobuf_dvb_register_bus() returns negative error codes on failure. This was introduced in e4425eab6b2: "V4L/DVB: cx23885: Check register errors".

Signed-off-by Dan Carpenter <[email protected]>

---
I don't have the hardware to test this, but it looks reversed.

drivers/media/video/cx23885/cx23885-dvb.c +1 -1

index 0a199d7..bf7c328 100644
@@ -991,7 +991,7 @@ static int dvb_register(struct cx23885_tsport *port)
 	ret = videobuf_dvb_register_bus(&port->frontends, THIS_MODULE, port,
 					&dev->pci->dev, adapter_nr, 0,
 					cx23885_dvb_fe_ioctl_override);
-	if (!ret)
+	if (ret < 0)
 		return ret;
 
 	/* init CI & MAC */