Skip to contentSkip to conversation

gspca for_2.6.36

PATCH Jean-Francois Moine 2 participants 2 messages Jun 22, 2010 – Jun 26, 2010 2 messages not in the archive

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive
Quoted 16 lines · On Mon, 21 Jun 2010 22:23:21 -0300 Mauro Carvalho Chehab <[email protected]>…
Quoted 8 lines

Jean-François Moine (15):
gspca - JPEG subdrivers: Don't allocate the JPEG header. gspca - stk014: Change the min and default values of the JPEG
quality. gspca - zc3xx: Change the max and default JPEG qualities.
gspca - zc3xx: Don't change the registers 7 and 8 for sensor
pas202b. gspca - zc3xx: Add back the brightness control.

gspca: Remove/move useless inclusions of slab.h.

This patch doesn't seem right. The addition of slab.h were done in order to allow the removal of the header from some core files. I'm not sure if all the upstream changes got applied to 2.6.35, but it seems prudent to wait for a while before just removing the headers, especially since the slab.h dependency may be different on non-Intel architectures.

Quoted 4 lines

I'm applying the remaining patches. If you think that this patch is correct, please re-send it to both LMML and LKML, c/c the authors of the slab.h removal, in order to get their acks, or, otherwise, please re-submit it for 2.6.37 window.

Hi Mauro,

The slab.h dependency was changed in the kernel 2.6.34 and its inclusion in some gspca source files was needed in case of the usage of kmalloc/kfree only.

After removing the JPEG header allocation, most gspca subdrivers do not use alloc/free anymore, so, there is no need to include slab.h anymore.

On the other side, this patch is easily checked because, if wrong, it raises compilation errors on any architecture.

Then, both patches (removal of JPEG alloc/free and slab.h inclusion) should go to 2.6.36.

Cheers.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#3 lore raw

Em 22-06-2010 05:42, Jean-Francois Moine escreveu:

Quoted 13 lines

On Mon, 21 Jun 2010 22:23:21 -0300

Quoted 4 lines

I'm applying the remaining patches. If you think that this patch is correct, please re-send it to both LMML and LKML, c/c the authors of the slab.h removal, in order to get their acks, or, otherwise, please re-submit it for 2.6.37 window.

Hi Mauro,

The slab.h dependency was changed in the kernel 2.6.34 and its inclusion in some gspca source files was needed in case of the usage of kmalloc/kfree only.

Quoted 8 lines

After removing the JPEG header allocation, most gspca subdrivers do not use alloc/free anymore, so, there is no need to include slab.h anymore.

On the other side, this patch is easily checked because, if wrong, it raises compilation errors on any architecture.

Then, both patches (removal of JPEG alloc/free and slab.h inclusion) should go to 2.6.36.

OK, makes sense. I'll apply the patch at staging/gspca.

Cheers,
Mauro.