Multiple issues after enabling SetVoltage on rs780m
Subsystems (2)
Hi Alex,
Your commit 9349d5cc920c10845693f906ebd67f394f1d0d04 (drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAM
These problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Rafael
01:05.0 VGA compatible controller: ATI Technologies Inc RS780M/RS780MN [Radeon HD 3200 Graphics] (prog-if 00 [VGA controller])
Subsystem: Acer Incorporated [ALI] Device 029e
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0, Cache Line Size: 32 bytes
Interrupt: pin A routed to IRQ 18
Region 0: Memory at a0000000 (32-bit, prefetchable) [size=256M]
Region 1: I/O ports at 9000 [size=256]
Region 2: Memory at 9fdf0000 (32-bit, non-prefetchable) [size=64K]
Region 5: Memory at 9fe00000 (32-bit, non-prefetchable) [size=1M]
Expansion ROM at <unassigned> [disabled]
Capabilities: [50] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [a0] MSI: Enable- Count=1/1 Maskable- 64bit+
Address: 0000000000000000 Data: 0000
Kernel driver in use: radeon
Dave Airlie
maintainerQuoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:
Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
Dave.
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
--
Dave Airlie
maintainerQuoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:
Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
are you sure its not 7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
Dave.
Quoted 14 lines · Dave Airlie
Quoted 13 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Quoted 8 lines
Quoted 1 line
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
Alex
From 8c055a2a5c0bd063fe2bf4797c585fd1cd59a673 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 7 Jun 2010 11:35:53 -0400
Subject: [PATCH] drm/radeon/kms/pm: Disable voltage adjust on RS780/RS880
The vddc value in the power tables is not an actual voltage like on discrete r6xx/r7xx/evergreen systems, but instead has a symbolic meaning (e.g., NONE, LOW, HIGH, etc.). See atombios.h
Most RS780/RS880 vbioses don't have a SetVoltage table anyway, so it shouldn't be doing anything to the hardware at the moment.
I need to figure out how voltage is supposed to work on the newer IGPs; until then, disable it.
--- drivers/gpu/drm/radeon/radeon_atombios.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/gpu/drm/radeon/radeon_atombios.c +1 -4
@@ -1841,10 +1841,7 @@ void radeon_atombios_get_power_modes(struct radeon_device *rdev)/* skip invalid modes */ if (rdev->pm.power_state[state_index].clock_info[mode_index].sclk ==0 )continue ; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.type = -VOLTAGE_SW ; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.voltage = - clock_info->usVDDC; +/* voltage works differently on IGPs */ mode_index++; }else if (ASIC_IS_DCE4 (rdev)) { struct _ATOM_PPLIB_EVERGREEN_CLOCK_INFO *clock_info =
Signature · 1 line
1.7.0.1
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
Quoted 14 lines · Dave Airlie
Quoted 13 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Quoted 8 lines
Quoted 1 line
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?
It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
Alex
From 8c055a2a5c0bd063fe2bf4797c585fd1cd59a673 Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Mon, 7 Jun 2010 11:35:53 -0400
Subject: [PATCH] drm/radeon/kms/pm: Disable voltage adjust on RS780/RS880
The vddc value in the power tables is not an actual voltage like on discrete r6xx/r7xx/evergreen systems, but instead has a symbolic meaning (e.g., NONE, LOW, HIGH, etc.). See atombios.h
Most RS780/RS880 vbioses don't have a SetVoltage table anyway, so it shouldn't be doing anything to the hardware at the moment.
I need to figure out how voltage is supposed to work on the newer IGPs; until then, disable it.
--- drivers/gpu/drm/radeon/radeon_atombios.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/gpu/drm/radeon/radeon_atombios.c +1 -4
@@ -1841,10 +1841,7 @@ void radeon_atombios_get_power_modes(struct radeon_device *rdev)/* skip invalid modes */ if (rdev->pm.power_state[state_index].clock_info[mode_index].sclk ==0 )continue ; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.type = -VOLTAGE_SW ; - rdev->pm.power_state[state_index].clock_info[mode_index].voltage.voltage = - clock_info->usVDDC; +/* voltage works differently on IGPs */ mode_index++; }else if (ASIC_IS_DCE4 (rdev)) { struct _ATOM_PPLIB_EVERGREEN_CLOCK_INFO *clock_info =
Signature · 1 line
1.7.0.1
Quoted 22 lines · Alex Deucher
Quoted 21 lines · Dave Airlie
Quoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
Quoted 8 lines
Quoted 1 line
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
I'm not sure if the adapter is a discrete one.
Anyway, my testing was done before commit 386f40c86d6c8d5b717ef20620af1a750d0dacb4 and I'm unable to reproduce the problems with current -git, so they might be a fallout of the bug fixed by that commit.
Thanks,
Rafael
Quoted 32 lines · Rafael J. Wysocki
Quoted 22 lines · Alex Deucher
Quoted 21 lines · Dave Airlie
Quoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
Quoted 8 lines
Quoted 1 line
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
Quoted 7 lines
I'm not sure if the adapter is a discrete one.
Anyway, my testing was done before commit
386f40c86d6c8d5b717ef20620af1a750d0dacb4and I'm unable to reproduce the problems with current -git, so they might be a fallout of the bug fixed by that commit.
Yeah the sounded a lot more like the vt.c crapfest, since it was when starting/stopping X.
Dave.
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
--
Quoted 32 lines · Rafael J. Wysocki
Quoted 22 lines · Alex Deucher
Quoted 21 lines · Dave Airlie
Quoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
Quoted 8 lines
Quoted 1 line
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
Quoted 7 lines
I'm not sure if the adapter is a discrete one.
Anyway, my testing was done before commit
386f40c86d6c8d5b717ef20620af1a750d0dacb4and I'm unable to reproduce the problems with current -git, so they might be a fallout of the bug fixed by that commit.
Yeah the sounded a lot more like the vt.c crapfest, since it was when starting/stopping X.
Dave.
Quoted 22 lines · Alex Deucher
Quoted 21 lines · Dave Airlie
Quoted 6 lines · Rafael J. Wysocki
Hi Alex,
Your commit
9349d5cc920c10845693f906ebd67f394f1d0d04(drm/radeon/kms/pm: enable SetVoltage on r7xx/evergreen) has caused my test-bed Acer Ferrari One to behave quite unreliably. The symptoms are:Quoted 8 lines
- the system hangs hard (~ 50% of the time) when starting Xorg
- the system hangs hard (~ 50% of the time) when stopping Xorg during system reboot
- the system sometimes hangs hard during suspend to RAMThese problems are not reproducible with the commit above reverted.
Below is the information about the graphics adapter from lspci.
Reverting that commit on master fixes it?
that commit touches code paths in rv770 and evergreen that in no way should affect that chipset which is an rs780, so takes the r600 paths.
Quoted 8 lines
Quoted 1 line
are you sure its not
7ac9aa5a1f1b87adb69bcbec2b89e228f074103a?It should be that commit if it is indeed the voltage adjust. That said, I just took a closer look at the voltage adjust on newer IGPs and unfortunately, it doesn't work the same as the discrete cards, so for now we should disable it. The attached patch should do the trick.
There weren't any problems on my IGP chips, but they don't have a
SetVoltage table, so nothing is touching the hw.
I'm not sure if the adapter is a discrete one.
Anyway, my testing was done before commit 386f40c86d6c8d5b717ef20620af1a750d0dacb4 and I'm unable to reproduce the problems with current -git, so they might be a fallout of the bug fixed by that commit.
Thanks,
Rafael
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
--