Skip to contentSkip to conversation

opensm/osm_trap_rcv.c: No need for heavy sweep when just NodeDescription changes

PATCH RESEND Applied Hal Rosenstock 2 participants 2 messages Jun 14, 2010 – Jun 17, 2010 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH RESEND 1/1 opensm/osm_trap_rcv.c: No need for heavy sweep when just NodeDescription changes

For trap 144s which indicate NodeDescription changed, there is no need for a heavy sweep if that is the only change indicated by the trap. Determine that by checking that there are no other change flags set and that the capability mask is unchanged. Still sweep if this is not the case (there is some other change).

Signed-off-by Hal Rosenstock <[email protected]>

---

opensm/opensm/osm_trap_rcv.c +4 -0
index 52f8832..9024a1f 100644
@@ -509,6 +509,9 @@ static void trap_rcv_process_request(IN osm_sm_t * sm,
 			CL_PLOCK_ACQUIRE(sm->p_lock);
 			osm_req_get_node_desc(sm, p_physp);
 			CL_PLOCK_RELEASE(sm->p_lock);
+			if (!(p_ntci->data_details.ntc_144.change_flgs & ~TRAP_144_MASK_NODE_DESCRIPTION_CHANGE) &&
+			    p_ntci->data_details.ntc_144.new_cap_mask == p_physp->port_info.capability_mask)
+				goto check_report;
 		} else
 			OSM_LOG(sm->p_log, OSM_LOG_ERROR,
 				"ERR 3812: No physical port found for "

@@ -547,6 +550,7 @@ check_sweep:
 	if (physp_change_trap == TRUE)
 		goto Exit;
 
+check_report:
 	/* Add a call to osm_report_notice */
 	/* We are going to report the notice - so need to fix the IssuerGID
 	   accordingly. See IBA 1.2 p.739 or IBA 1.1 p.653 for details. */

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

Applied
#2 lore raw
Quoted 8 lines · Hal Rosenstock

For trap 144s which indicate NodeDescription changed, there is no need for a heavy sweep if that is the only change indicated by the trap. Determine that by checking that there are no other change flags set and that the capability mask is unchanged. Still sweep if this is not the case (there is some other change).

Signed-off-by Hal Rosenstock <[email protected]>

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html