Skip to contentSkip to conversation

pci: off by one in dmar_get_fault_reason()

PATCH New Dan Carpenter 1 participant 1 message Jun 21, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci: off by one in dmar_get_fault_reason()

This should be '<' here instead of '<=' so we don't go past the end of the array.

drivers/pci/dmar.c +1 -1
index 0a19708..3043636 100644
@@ -1208,7 +1208,7 @@ static const char *intr_remap_fault_reasons[]  
 const char *dmar_get_fault_reason(u8 fault_reason, int *fault_type)
 {
-	if (fault_reason >= 0x20 && (fault_reason <= 0x20 +
+	if (fault_reason >= 0x20 && (fault_reason < 0x20 +
 				     ARRAY_SIZE(intr_remap_fault_reasons))) {
 		*fault_type = INTR_REMAP;
 		return intr_remap_fault_reasons[fault_reason - 0x20];