Skip to contentSkip to conversation

make-release: fix mtime on rhel6 beta

PATCH Applied Michael S. Tsirkin 2 participants 2 messages Jun 24, 2010 – Jun 28, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 make-release: fix mtime on rhel6 beta

With recent git versions (like one in rhel6 beta), git prints out tag info in addition to requested format, if passed a tag name. This breaks make-release.
To get just the time as we want, we need to pass something that is not a tag name but matches same commit. $commit^{commit} does this.

---
Changes from v1: use ^{commit} for clarity.

 kvm/scripts/make-release |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kvm/scripts/make-release +1 -1
index e8051f4..64e77f9 100755
@@ -51,7 +51,7 @@ cd "$(dirname "$0")"/../..
 mkdir -p "$(dirname "$tarball")"
 git archive --prefix="$name/" --format=tar "$commit" > "$tarball"
 
-mtime=`git show --format=%ct "$commit" --`
+mtime=`git show --format=%ct "$commit""^{commit}" --`
 tarargs="--owner=root --group=root --mtime=@$mtime"
 
 mkdir -p "$tmpdir"
Signature · 1 line
1.7.1.12.g42b7f
#1 lore raw
Quoted 9 lines · Michael S. Tsirkin

With recent git versions (like one in rhel6 beta), git prints out tag info in addition to requested format, if passed a tag name. This breaks make-release.
To get just the time as we want, we need to pass something that is not a tag name but matches same commit. $commit^{commit} does this.

Applied, thanks.