Skip to contentSkip to conversation

RFC: Don't enable both cpuidle governors when NO_HZ is enabled.

PATCH Dave Jones 1 participant 1 message Jun 25, 2010 CPU idle time management framework

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Does this patch make sense ?

I noticed we setup both governors during boot..

kernel: [ 3.387035] cpuidle: using governor ladder
kernel: [ 3.391541] cpuidle: using governor menu

which seems wasteful.

With this patch, we configure either ladder, or menu, depending on whether NO_HZ is set.

drivers/cpuidle/Kconfig renamed from drivers/cpuidle/Kconfig~ +1 -1
@@ -11,7 +11,7 @@ config CPU_IDLE
 
 config CPU_IDLE_GOV_LADDER
 	bool
-	depends on CPU_IDLE
+	depends on CPU_IDLE && !NO_HZ
 	default y
 
 config CPU_IDLE_GOV_MENU