cpumask: select disabling obsolete cpumask functions on x86
Subsystems (3)
PATCH 3/5 cpumask: select disabling obsolete cpumask functions on x86
It currently depends on CONFIG_BROKEN; change to be set by CONFIG_CPUMASK_OFFSTACK now it all compiles.
We also complete it: the header shouldn't refer to the deprected CPU_MASK_LAST_WORD, and the deprecated implementations are removed.
Signed-off-by Rusty Russell <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc KOSAKI Motohiro <[email protected]>
Cc Mike Travis <[email protected]>
--- include/linux/cpumask.h | 4 ++-- include/linux/sched.h | 2 +- lib/Kconfig | 5 ++++- lib/cpumask.c | 2 ++ 4 files changed, 9 insertions(+), 4 deletions(-)
include/linux/cpumask.h +2 -2
@@ -700,7 +700,7 @@ static inline const struct cpumask *get_#if NR_CPUS <=BITS_PER_LONG #define CPU_BITS_ALL \ { \ - [BITS_TO_LONGS(NR_CPUS)-1] = CPU_MASK_LAST_WORD \ + [BITS_TO_LONGS(NR_CPUS)-1] = BITMAP_LAST_WORD_MASK(NR_CPUS) \ }#else /* NR_CPUS > BITS_PER_LONG */
@@ -708,7 +708,7 @@ static inline const struct cpumask *get_#define CPU_BITS_ALL \ { \ [0 ... BITS_TO_LONGS(NR_CPUS)-2] = ~0UL, \ - [BITS_TO_LONGS(NR_CPUS)-1] = CPU_MASK_LAST_WORD \ + [BITS_TO_LONGS(NR_CPUS)-1] = BITMAP_LAST_WORD_MASK(NR_CPUS) \ }#endif /* NR_CPUS > BITS_PER_LONG */
include/linux/sched.h +1 -1
@@ -1826,7 +1826,7 @@ static inline int set_cpus_allowed_ptr(s }#endif -#ifndef CONFIG_CPUMASK_OFFSTACK +#ifndef CONFIG_DISABLE_OBSOLETE_CPUMASK_FUNCTIONS static inline int set_cpus_allowed (struct task_struct *p,cpumask_t new_mask) {return set_cpus_allowed_ptr (p, &new_mask);
lib/Kconfig +4 -1
@@ -179,6 +179,7 @@ config HAVE_LMB config CPUMASK_OFFSTACK bool "Force CPU masks off stack" if DEBUG_PER_CPU_MAPS + select DISABLE_OBSOLETE_CPUMASK_FUNCTIONS help Use dynamic allocation for cpumask_var_t, instead of putting them on the stack. This is a bit more expensive, but avoids
@@ -186,7 +187,9 @@ config CPUMASK_OFFSTACK config DISABLE_OBSOLETE_CPUMASK_FUNCTIONS bool "Disable obsolete cpumask functions" if DEBUG_PER_CPU_MAPS - depends on EXPERIMENTAL && BROKEN + help + Remove all the definitions of things which are dangerous with + offstack (ie. dynamically allocated) cpumasks. # # Netlink attribute parsing support is select'ed if needed
lib/cpumask.c +2 -0
@@ -4,6 +4,7 @@#include <linux/module.h> #include <linux/bootmem.h> +#ifndef CONFIG_DISABLE_OBSOLETE_CPUMASK_FUNCTIONS int __first_cpu (const cpumask_t *srcp) {return min_t (int,NR_CPUS ,find_first_bit (srcp->bits,NR_CPUS ));
@@ -36,6 +37,7 @@ int __any_online_cpu(const cpumask_t *ma return cpu; }EXPORT_SYMBOL (__any_online_cpu); +#endif /* CONFIG_DISABLE_OBSOLETE_CPUMASK_FUNCTIONS */ /** * cpumask_next_and - get the next cpu in *src1p & *src2p