Remove files which does not have a dmesg entry

Quoted 6 lines · On Monday, June 28, 2010 07:52:18 Subrata Modak wrote:

+     if [ $ALT_DMESG_OUT -eq 1 ] ; then
+             PWD=pwd
+             cd $DMESG_DIR
+             for dmesg_file in ls
+             do
+                     dmesg_file_size=`wc -c $dmesg_file | cut -d ' ' -f1 | tr -d

'\n'`

Quoted 6 lines

+                     if [ $dmesg_file_size -eq 0 ]; then
+                             rm -rf $dmesg_file
+                     fi
+             done
+             cd $PWD
+     fi

ugh.  what's wrong with simply executing:
       find "$DMESG_DIR" -size 0 -exec rm {} +

Quoted 1 line

+     if [ ls -l $DMESG_DIR | wc -l -ge 1 ]; then

if [ -n "$(ls "$DMESG_DIR")" ] ; then
-mike

Quoted 18 lines · Mike Frysinger

runltp main()

Quoted 7 lines · On Monday, June 28, 2010 07:52:18 Subrata Modak wrote:

runltp renamed from runltp.orig +6 -1

+     if [ $ALT_DMESG_OUT -eq 1 ] ; then
+             PWD=`pwd`
+             cd $DMESG_DIR
+             for dmesg_file in `ls`
+             do
+                     dmesg_file_size=`wc -c $dmesg_file | cut -d ' '
-f1 | tr -d

'\n'`

Quoted 6 lines

runltp renamed from runltp.orig +6 -0

+                     if [ $dmesg_file_size -eq 0 ]; then
+                             rm -rf $dmesg_file
+                     fi
+             done
+             cd $PWD
+     fi

Quoted 2 lines

ugh. what's wrong with simply executing:

       find "$DMESG_DIR" -size 0 -exec rm {} +

Or find "$DMESG_DIR" -size 0 | xargs rm -f ?

Hi,

The recently introduced option:

-K DMESG_LOG_DIR
       Log Kernel messages generated for each test cases inside this directory,

when used will generate huge no. of files inside the DMESG_DIR. Many of them will be ZERO size as we do not expect KERNEL MESSAGE to be generated against all the LTP TESTS that we will run. It is better to prune them, and let only those files exist which will have real entries. The following patch fixes the same.

Signed-off-by Subrata Modak <[email protected]>,

---

runltp  2010-06-28 10:21:04.000000000 +0530 renamed from runltp.orig     2010-06-28 10:02:42.000000000 +0530 +0 -0

@@ -858,6 +858,30 @@ main()

    cd ..
    echo "LTP Version: $version_date"

+       # DMESG_DIR will contain hell lot of files which will not have any entry
+       # since kernel message(s) will not be generated for every test. The zero size
+       # files will clog the directory. Lets keep only those fules which have real
+       # kernel message entries. If DMESG_DIR directroy is empty after test run, it
+       # will indicate that no kernel message was generated during test run +

+       if [ $ALT_DMESG_OUT -eq 1 ] ; then
+               PWD=pwd

+               cd $DMESG_DIR

+               for dmesg_file in ls
+               do
+                       dmesg_file_size=wc -c $dmesg_file | cut -d ' ' -f1 | tr -d '\n'
+                       if [ $dmesg_file_size -eq 0 ]; then
+                               rm -rf $dmesg_file
+                       fi
+               done
+               cd $PWD
+       fi

runltp main() · line 868

Quoted 2 lines · Subrata Modak

runltp renamed from runltp.orig +2 -0

+       if [ $ALT_DMESG_OUT -eq 1 ] ; then
+               PWD=`pwd`

Please use a different variable name. This obfuscates the meaning of the shell set value.