Skip to contentSkip to conversation

s5pc110: Reduce the iodesc length of systimer

PATCH New Kyungmin Park 3 participants 6 messages Jul 8, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

From: Kyungmin Park <[email protected]>

It's enough to use 4KiB.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-s5pv210/cpu.c +1 -1
index 411a4a9..07b86d2 100644
@@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
 	{
 		.virtual	= (unsigned long)S5P_VA_SYSTIMER,
 		.pfn		= __phys_to_pfn(S5PV210_PA_SYSTIMER),
-		.length		= SZ_1M,
+		.length		= SZ_4K,
 		.type		= MT_DEVICE,
 	}, {
 		.virtual	= (unsigned long)VA_VIC2,
#1 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

Quoted 6 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's enough to use 4KiB.

Signed-off-by Kyungmin Park <[email protected]>

Where is submitter(kmpark at infradead.org)'s Signed-off-by? I know submitter and author in here are same...but e-mail. So added 'From' in your patch.

It would be helpful to me if you use same e-mail in a patch.

Also, the commit message needs to be more descriptive.

Quoted 7 lines

---

arch/arm/mach-s5pv210/cpu.c +0 -0
index 411a4a9..07b86d2 100644

arch/arm/mach-s5pv210/cpu.c static struct map_desc s5pv210_iodesc[] __initdata = { · line 47

Quoted 8 lines
arch/arm/mach-s5pv210/cpu.c +1 -1
@@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
 	{
 		.virtual	= (unsigned long)S5P_VA_SYSTIMER,
 		.pfn		= __phys_to_pfn(S5PV210_PA_SYSTIMER),
-		.length		= SZ_1M,
+		.length		= SZ_4K,
 		.type		= MT_DEVICE,
 	}, {
 		.virtual	= (unsigned long)VA_VIC2,

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#5 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

In reply to Kyungmin Park
Quoted 9 lines · Kukjin Kim
Quoted 6 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's enough to use 4KiB.

Signed-off-by Kyungmin Park <[email protected]>
Quoted 8 lines

Where is submitter(kmpark at infradead.org)'s Signed-off-by? I know submitter and author in here are same...but e-mail. So added 'From' in your patch.

It would be helpful to me if you use same e-mail in a patch.

Also, the commit message needs to be more descriptive.

I mean following is better.
'This patch reduces the iodesc length of System Timer from 1M to 4K.'

May I apply this patch with above modified message?

Quoted 7 lines
Quoted 7 lines

---

arch/arm/mach-s5pv210/cpu.c +0 -0
index 411a4a9..07b86d2 100644
@@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
 	{
Quoted 9 lines

arch/arm/mach-s5pv210/cpu.c static struct map_desc s5pv210_iodesc[] __initdata = { · line 47

Quoted 8 lines
arch/arm/mach-s5pv210/cpu.c +1 -1
 		.virtual	= (unsigned long)S5P_VA_SYSTIMER,
 		.pfn		= __phys_to_pfn(S5PV210_PA_SYSTIMER),
-		.length		= SZ_1M,
+		.length		= SZ_4K,
 		.type		= MT_DEVICE,
 	}, {
 		.virtual	= (unsigned long)VA_VIC2,

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

author
#2 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

In reply to Kukjin Kim

Hi Andrew,

Can you explain Mr. Kim request?
As your suggestion, If the sender and signed-off are different, add the From filed at body.

I think no need to add duplicated signed-off since it's same person.

Thank you,
Kyungmin Park

Quoted 41 lines · Kukjin Kim
Quoted 6 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's enough to use 4KiB.

Signed-off-by Kyungmin Park <[email protected]>

Where is submitter(kmpark at infradead.org)'s Signed-off-by? I know submitter and author in here are same...but e-mail. So added 'From' in your patch.

It would be helpful to me if you use same e-mail in a patch.

Also, the commit message needs to be more descriptive.

Quoted 7 lines

---

arch/arm/mach-s5pv210/cpu.c +0 -0
index 411a4a9..07b86d2 100644

arch/arm/mach-s5pv210/cpu.c static struct map_desc s5pv210_iodesc[] __initdata = { · line 47

Quoted 8 lines
arch/arm/mach-s5pv210/cpu.c +1 -1
@@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
 ? ? ? {
 ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)S5P_VA_SYSTIMER,
 ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(S5PV210_PA_SYSTIMER),
- ? ? ? ? ? ? .length ? ? ? ? = SZ_1M,
+ ? ? ? ? ? ? .length ? ? ? ? = SZ_4K,
 ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE,
 ? ? ? }, {
 ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)VA_VIC2,

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#3 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

Quoted 7 lines · Kyungmin Park

Hi Andrew,

Can you explain Mr. Kim request?
As your suggestion, If the sender and signed-off are different, add the From filed at body.

Yes I know, didn't see my posing?
In this case, my suggestion is just use same e-mail in a patch.

Quoted 2 lines

I think no need to add duplicated signed-off since it's same person.

Maybe you misunderstood my comments.

Quoted 19 lines

Thank you,
Kyungmin Park

Quoted 14 lines · Kukjin Kim
Quoted 6 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's enough to use 4KiB.

Signed-off-by Kyungmin Park <[email protected]>

Where is submitter(kmpark at infradead.org)'s Signed-off-by? I know submitter and author in here are same...but e-mail. So added 'From' in your patch.

It would be helpful to me if you use same e-mail in a patch.

Quoted 8 lines
Quoted 8 lines

Also, the commit message needs to be more descriptive.

arch/arm/mach-s5pv210/cpu.c static struct map_desc s5pv210_iodesc[] __initdata =

Quoted 6 lines

---

arch/arm/mach-s5pv210/cpu.c +0 -0
index 411a4a9..07b86d2 100644
@@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata =

{

Quoted 10 lines
Quoted 10 lines

arch/arm/mach-s5pv210/cpu.c static struct map_desc s5pv210_iodesc[] __initdata = · line 47

Quoted 9 lines
arch/arm/mach-s5pv210/cpu.c +1 -1
 ? ? ? {
 ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)S5P_VA_SYSTIMER,
 ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(S5PV210_PA_SYSTIMER),
- ? ? ? ? ? ? .length ? ? ? ? = SZ_1M,
+ ? ? ? ? ? ? .length ? ? ? ? = SZ_4K,
 ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE,
 ? ? ? }, {
 ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)VA_VIC2,

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#4 lore raw

PATCH 1/1 s5pc110: Reduce the iodesc length of systimer

In reply to Kyungmin Park
Quoted 5 lines · On Thu, 8 Jul 2010 20:40:39 +0900 Kyungmin Park <[email protected]> wrote:

Can you explain Mr. Kim request?
As your suggestion, If the sender and signed-off are different, add the From filed at body.

I think no need to add duplicated signed-off since it's same person.

If you're sending a patch which someone else wrote then at a minimum it should have that person's From: at the top of the changelog and it should have your Signed-off-by:.

However it is not required that the patch have the author's Signed-off-by:. See Documentation/SubmittingPatches, section 12. If you sent the patch and signed it then _you_ assert that it's OK to include the patch in Linux.

That being said, we do prefer that both the author and the sender include their signoffs.