kgdb: strlen() doesn't count the terminator

PATCH New Dan Carpenter 1 participant 1 message Jul 10, 2010

Subsystems (3)

Kernel janitors Char and misc drivers KGDB / KDB /debug_core

lore

Share & tools

lore

Dan Carpenter

author

2010-07-10 09:29 UTC #0 lore raw

PATCH 1/1 kgdb: strlen() doesn't count the terminator

This is an off by one because strlen() doesn't count the null terminator. We strcpy() these strings into an array of size MAX_CONFIG_LEN.

Signed-off-by Dan Carpenter <[email protected]>

drivers/misc/kgdbts.c +1 -1

index 7245023..799ea0a 100644
@@ -988,7 +988,7 @@ static void kgdbts_run_tests(void)
 
 static int kgdbts_option_setup(char *opt)
 {
-	if (strlen(opt) > MAX_CONFIG_LEN) {
+	if (strlen(opt) >= MAX_CONFIG_LEN) {
 		printk(KERN_ERR "kgdbts: config string too long\n");
 		return -ENOSPC;
 	}

drivers/serial/kgdboc.c +1 -1

index a9a94ae..ba7b7c6 100644
@@ -70,7 +70,7 @@ static void kgdboc_unregister_kbd(void)
 
 static int kgdboc_option_setup(char *opt)
 {
-	if (strlen(opt) > MAX_CONFIG_LEN) {
+	if (strlen(opt) >= MAX_CONFIG_LEN) {
 		printk(KERN_ERR "kgdboc: config string too long\n");
 		return -ENOSPC;
 	}