TODO list

Quoted 14 lines

Hello everyone,
I am new to the mailing list and to the kernel and I was wondering if there are some basics things I could do like fix warnings or else to avoid
to complex patches at firstÅ
There was http://kernelnewbies.org/KernelJanitors/Todo but it was last edited 2009-04-20 14:59:47 by HenrikKretzschmar.

Any Ideas ? Thanks ! =)
Benjamin

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

* check kmallocs for things like GFP_DMA without a memtype.

Quoted 8 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

Quoted 2 lines

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

There are still the occasional GFP_DMA without a memtype issue. I'm not certain what the fix is for those. You could probably find them using Coccinelle.

regards,
dan carpenter

Quoted 9 lines · Dan Carpenter

Quoted 8 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

Quoted 8 lines

Quoted 2 lines

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

Thanks Dan. Do you recommend anything else for contribution? I am not a newbie to kernel but never contributed to kernel before so any inputs appreciated.

Quoted 21 lines · Ravi Kerur

Quoted 17 lines · Dan Carpenter

Quoted 10 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

Quoted 3 lines

Thanks Dan. Do you recommend anything else for contribution? I am not a newbie to kernel but never contributed to kernel before so any inputs appreciated.

There is always stuff to fix in staging. It's at all levels of difficulty.

regards,
dan carpenter

Quoted 22 lines · Dan Carpenter

Quoted 21 lines · Ravi Kerur

Quoted 17 lines · Dan Carpenter

Quoted 10 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

Quoted 6 lines

Quoted 3 lines

Thanks Dan. Do you recommend anything else for contribution? I am not a newbie to kernel but never contributed to kernel before so any inputs appreciated.

There is always stuff to fix in staging. It's at all levels of difficulty.

Can you please point me to the link or anything which lists what needs to be done. I can pick some of it.

Quoted 32 lines · Ravi Kerur

Quoted 28 lines · Dan Carpenter

Quoted 21 lines · Ravi Kerur

Quoted 9 lines · Dan Carpenter

Quoted 8 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

Quoted 8 lines

Quoted 2 lines

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

Quoted 3 lines

Thanks Dan. Do you recommend anything else for contribution? I am not a newbie to kernel but never contributed to kernel before so any inputs appreciated.

There is always stuff to fix in staging. It's at all levels of difficulty.

Quoted 1 line

Can you please point me to the link or anything which lists what needs to be done. I can pick some of it.

You can run checkpatch, or other tools and fix the things that they highlight. Once you start really looking at the code, you are likely to see other things that can be improved as well. Some staging drivers also have TODO lists.

julia

Quoted 38 lines · Julia Lawall

Quoted 33 lines · Ravi Kerur

Quoted 22 lines · Dan Carpenter

Quoted 21 lines · Ravi Kerur

Quoted 17 lines · Dan Carpenter

Quoted 10 lines · Ravi Kerur

Team,

I am planning to take up following items from TODO list. If it's already picked please let me know.

* pci_set_dma_mask() and friends should use DMA_BIT_MASK(nn) instead of

DMA_nnBIT_MASK or 0xffff... This is not 2.4 compatible, so beware of drivers with same code. [D: http://marc.theaimsgroup.com/?t8001993000001] Don't forget to #include dma-mapping.h

* check kmallocs for things like GFP_DMA without a memtype.

The TODO is desperately out of date. No one cares about 2.4 at all. These days we don't really allow drivers to have backwards compatability code so they compile on old kernels. That stuff has to be stored out of the main kernel tree. We also have the compat-wireless and other similar ways of backporting drivers.

Quoted 6 lines

Quoted 3 lines

Thanks Dan. Do you recommend anything else for contribution? I am not a newbie to kernel but never contributed to kernel before so any inputs appreciated.

There is always stuff to fix in staging. It's at all levels of difficulty.

Can you please point me to the link or anything which lists what needs to be done. I can pick some of it.

Quoted 5 lines

You can run checkpatch, or other tools and fix the things that they highlight. Once you start really looking at the code, you are likely to see other things that can be improved as well. Some staging drivers also have TODO lists.

My question was which subsystem or specific area to start? Should I pick some random subsystem of my interest and start working on it?

Team,

I will take up net/sched files and get a clean checkpatch run on them. I am working on a project which involves this piece of code and as part of learning the code I can clean-up the files. I ran checkpatch on some of them and I do see that it needs cleaning. For e.g.

#:~/git/kernels/staging$ perl scripts/checkpatch.pl -f net/sched/act_api.c
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#41: FILE: net/sched/act_api.c:41:

(quoted diff) +2 -0

+	/*
+	 * gen_estimator est_timer() might access p->tcfc_locki

CHECK: Comparison to NULL could be written "!nest" #95: FILE: net/sched/act_api.c:95:

Quoted 10 lines · Ravi Kerur

Team,

I will take up net/sched files and get a clean checkpatch run on them. I am working on a project which involves this piece of code and as part of learning the code I can clean-up the files. I ran checkpatch on some of them and I do see that it needs cleaning. For e.g.

#:~/git/kernels/staging$ perl scripts/checkpatch.pl -f net/sched/act_api.c
WARNING: networking block comments don't use an empty /* line, use /* Comment...
#41: FILE: net/sched/act_api.c:41:

(quoted diff) +2 -0

+	/*
+	 * gen_estimator est_timer() might access p->tcfc_locki

Review

Quoted 5 lines

CHECK: Comparison to NULL could be written "!nest" #95: FILE: net/sched/act_api.c:95:

(quoted diff) +1 -0

+			if (nest = NULL)
...
[...]

No one cares about either of those things. If it's a drivers/staging patch then we would merge it, but if it's a patch to net/sched/act_api.c they will probably just get annoyed with you.

regards,
dan carpenter

Thanks, The reason I didn't pick from drivers/staging is that I don't have necessary hardware to test the changes. Hence I chose something which can be tested without any restriction and get it done. Do you have any recommendations?