Make CONFIG_DEBUG_RODATA boot-time configurable
We had a request to disable DEBUG_RODATA in our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.
init/main.c +11 -1
@@ -820,6 +820,15 @@ static void run_init_process(char *init_filename)kernel_execve (init_filename, argv_init, envp_init); } +static unsigned int disable_rodata; +static int __init set_disable_rodata (char *str) +{ + disable_rodata =1 ; +return 1 ; +} +__setup ("disable_rodata" , set_disable_rodata); + +/* This is a non __init function. Force it to be noinline otherwise gcc * makes it inline to init() and it becomes part of init.text section */
@@ -830,7 +839,8 @@ static noinline int init_post(void)async_synchronize_full ();free_initmem ();unlock_kernel (); -mark_rodata_ro (); +if (disable_rodata ==0 ) +mark_rodata_ro (); system_state =SYSTEM_RUNNING ;numa_default_policy ();
Documentation/kernel-parameters.txt +4 -0
@@ -651,6 +651,10 @@ and is between 256 and 4096 characters. It is defined in the file MTRR settings. This parameter disables that behavior, possibly causing your machine to run very slowly. + disable_rodata [X86] + Don't mark .rodata section as read-only. + May be useful for debugging. + disable_timer_pin_1 [X86] Disable PIN 1 of APIC timer Can be useful to work around chipset bugs.
Quoted 42 lines · On Thu, 15 Jul 2010 17:09:44 -0400 Dave Jones wrote:
We had a request to disable
DEBUG_RODATAin our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.Signed-off-by Dave Jones <[email protected]>init/main.c +11
-1@@ -820,6 +820,15 @@ static void run_init_process(char *init_filename)kernel_execve (init_filename, argv_init, envp_init); } +static unsigned int disable_rodata; +static int __init set_disable_rodata (char *str) +{ + disable_rodata =1 ; +return 1 ; +} +__setup ("disable_rodata" , set_disable_rodata); + +/* This is a non __init function. Force it to be noinline otherwise gcc * makes it inline to init() and it becomes part of init.text section */ @@ -830,7 +839,8 @@ static noinline int init_post(void)async_synchronize_full ();free_initmem ();unlock_kernel (); -mark_rodata_ro (); +if (disable_rodata ==0 ) +mark_rodata_ro (); system_state =SYSTEM_RUNNING ;numa_default_policy ();Documentation/kernel-parameters.txt +0
-0
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 654
Quoted 4 lines
Documentation/kernel-parameters.txt +1
-0@@ -651,6 +651,10 @@ and is between 256 and 4096 characters. It is defined in the file MTRR settings. This parameter disables that behavior, possibly causing your machine to run very slowly. + disable_rodata [X86]
What is X86-specific about this boot option?
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file
Quoted 7 lines
Documentation/kernel-parameters.txt +3
-1+ Don't mark .rodata section as read-only. + May be useful for debugging. + disable_timer_pin_1 [X86] Disable PIN 1 of APIC timer Can be useful to work around chipset bugs. --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Quoted 11 lines · Randy Dunlap
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 654
Quoted 9 lines
Documentation/kernel-parameters.txt +1
-0@@ -651,6 +651,10 @@ and is between 256 and 4096 characters. It is defined in the file MTRR settings. This parameter disables that behavior, possibly causing your machine to run very slowly. + disable_rodata [X86]What is X86-specific about this boot option?
Just hadn't realized that other archs had implemented it.
Dave
Quoted 6 lines · Dave Jones
We had a request to disable
DEBUG_RODATAin our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.Signed-off-by Dave Jones <[email protected]>
Nice one, shouldn't we get rid of the DEBUG_RODATA config and enable it unconditionally ?
Thanks,
tglx
Quoted 11 lines · Thomas Gleixner
Quoted 6 lines · Dave Jones
We had a request to disable
DEBUG_RODATAin our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.Signed-off-by Dave Jones <[email protected]>Nice one, shouldn't we get rid of the
DEBUG_RODATAconfig and enable it unconditionally ?
I personally have no objection, but others might. follow-up patch rather than including it in this maybe?
Dave
Quoted 4 lines · On Thu, 15 Jul 2010 17:09:44 -0400 Dave Jones <[email protected]> wrote:
We had a request to disable
DEBUG_RODATAin our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.
I'd be very curious what kind of debugging this is... is this the rootkit type of debugging?
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
Quoted 8 lines · On Fri, 16 Jul 2010 00:06:16 +0200 (CEST) Thomas Gleixner <[email protected]>…
Quoted 6 lines · Dave Jones
We had a request to disable
DEBUG_RODATAin our kernel for debugging purposes. Turning it off completely seems a bit unfortunate for the minority case of people wanting to do debugging, so I came up with this patch to make it a boot-time 'disable_rodata' argument.
Quoted 5 lines
Quoted 1 line
Signed-off-by Dave Jones <[email protected]>Nice one, shouldn't we get rid of the
DEBUG_RODATAconfig and enable it unconditionally ?
I'd go one step further; enable unconditional, and have the config option control if you can turn it off or not...