Skip to contentSkip to conversation

KERNEL BUILD: Make the setlocalversion script POSIX-compliant.

PATCH In review Michał Górny 2 participants 3 messages Jul 18, 2010 – Jul 20, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KERNEL BUILD: Make the setlocalversion script POSIX-compliant.

The 'source' builtin is a bash alias to the '.' (dot) builtin. While the former is supported only by bash, the latter is specified in POSIX and works fine with all POSIX-compliant shells I am aware of.

The '$_' special parameter is specific to bash. It is partially supported in dash too but it always evaluates to the current script path (which causes the script to enter a loop recursively re-executing itself). This is why I have replaced the two occurences of '$_' with the explicit parameter.

The 'local' builtin is another example of bash-specific code. Although it is supported by all POSIX-compliant shells I am aware of, it is not part of POSIX specification and thus the code should not rely on it assigning a specific value to the local variable. Moreover, the 'posh' shell has a limited version of 'local' builtin not supporting direct variable assignments. Thus, I have broken one of the 'local' declarations down into a (non-POSIX) 'local' declaration and a plain (POSIX-compliant) variable assignment.

---

There is one 'bashism' left which I wasn't able to fix -- the use of 'test -ef'. I'm not aware of any POSIX equivalent of that.

 scripts/setlocalversion |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
scripts/setlocalversion +4 -3
index d6a866e..a7b9f76 100755
@@ -30,11 +30,12 @@ fi
 
 scm_version()
 {
-	local short=false
+	local short
+	short=false
 
 	cd "$srctree"
 	if test -e .scmversion; then
-		cat "$_"
+		cat .scmversion
 		return
 	fi
 	if test "$1" = "--short"; then
@@ -136,7 +137,7 @@ if $scm_only; then
 fi
 
 if test -e include/config/auto.conf; then
-	source "$_"
+	. include/config/auto.conf
 else
 	echo "Error: kernelrelease not valid - run 'make prepare' to update it"
 	exit 1
Signature · 1 line
1.7.1.1
#1 lore raw
Quoted 19 lines · Michał Górny

The 'source' builtin is a bash alias to the '.' (dot) builtin. While the former is supported only by bash, the latter is specified in POSIX and works fine with all POSIX-compliant shells I am aware of.

The '$_' special parameter is specific to bash. It is partially supported in dash too but it always evaluates to the current script path (which causes the script to enter a loop recursively re-executing itself). This is why I have replaced the two occurences of '$_' with the explicit parameter.

The 'local' builtin is another example of bash-specific code. Although it is supported by all POSIX-compliant shells I am aware of, it is not part of POSIX specification and thus the code should not rely on it assigning a specific value to the local variable. Moreover, the 'posh' shell has a limited version of 'local' builtin not supporting direct variable assignments. Thus, I have broken one of the 'local' declarations down into a (non-POSIX) 'local' declaration and a plain (POSIX-compliant) variable assignment.

Quoted 1 line

Thanks a lot, applied to the kbuild tree.

Quoted 4 lines

---

There is one 'bashism' left which I wasn't able to fix -- the use of 'test -ef'. I'm not aware of any POSIX equivalent of that.

Me neither, POSIX does not know stat(1) AFAICS. Does it matter in real life? Is there a distro that installs posh or a similarly strict shell as /bin/sh? It seems to work with dash after your changes.

Michal

#2 lore raw
Quoted 6 lines · On Tue, 20 Jul 2010 16:00:29 +0200 Michal Marek <[email protected]> wrote:
Quoted 2 lines

There is one 'bashism' left which I wasn't able to fix -- the use of 'test -ef'. I'm not aware of any POSIX equivalent of that.

Me neither, POSIX does not know stat(1) AFAICS. Does it matter in real life? Is there a distro that installs posh or a similarly strict shell as /bin/sh? It seems to work with dash after your changes.

I am not aware of any, and it does work with dash indeed. That's why I have submitted the patch. I left that notice mostly because the actual description suggested the script becomes 'POSIX-compliant'.

The second reason for that notice is that someone might want to fix that sometime. But I guess the best way would be through complete change of the check logic.

Signature · 5 lines
Best regards,
Michał Górny

<http://mgorny.alt.pl>
<xmpp:[email protected]>