write_ports delfd case

Does anyone know what __write_ports_delfd() is meant to do?

The block comment above write_ports claims it handles writes of the form "-<file descriptor>", which makes no sense (the file table of the writer has nothing to do with anything). It's called only when the character after the "-" is a digit, but the names it matches against (generated by svc_one_sock_name()) start with "ipv4" or "ipv6".

Quoted 7 lines · J. Bruce Fields

Does anyone know what __write_ports_delfd() is meant to do?

The block comment above write_ports claims it handles writes of the form "-<file descriptor>", which makes no sense (the file table of the writer has nothing to do with anything). It's called only when the character after the "-" is a digit, but the names it matches against (generated by svc_one_sock_name()) start with "ipv4" or "ipv6".

I suspect the comment above write_ports() is not correct. I assumed that delfd was symmetrical with addfd, but it isn't. More likely, addfd returns a string name that can be passed to write_ports (with a preceding '-') to terminate the socket.

Quoted 9 lines · On Mon, 19 Jul 2010 15:32:57 -0400 Chuck Lever <[email protected]> wrote:

Quoted 7 lines · J. Bruce Fields

Does anyone know what __write_ports_delfd() is meant to do?

The block comment above write_ports claims it handles writes of the form "-<file descriptor>", which makes no sense (the file table of the writer has nothing to do with anything). It's called only when the character after the "-" is a digit, but the names it matches against (generated by svc_one_sock_name()) start with "ipv4" or "ipv6".

Quoted 4 lines

I suspect the comment above write_ports() is not correct. I assumed that delfd was symmetrical with addfd, but it isn't. More likely, addfd returns a string name that can be passed to write_ports (with a preceding '-') to terminate the socket.

Yeah -- seems broken to me. Given that it clearly doesn't work and I'm not aware of anyone having complained, perhaps it would be best to remove it?