libxl: fix linking error
PATCH 1/1 libxl: fix linking error
Hi!
Attached patch fixes linking error when creating the xl binary. The xl binary compiles in xl_cmdimpl.c which calls code from libxl_paths.c and libxl_bootloader.c.
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
tools/libxl/Makefile +1 -1
@@ -87,7 +87,7 @@ xl_cmdimpl.o: xl_cmdimpl.c xl_cmdtable.o: xl_cmdtable.c $(CC) $(CFLAGS) -c xl_cmdtable.c -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so $(CC) $(LDFLAGS) -o $@ $^ $(LIBS) .PHONY: install
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
Quoted 3 lines
Attached patch fixes linking error when creating the xl binary. The xl binary compiles in
xl_cmdimpl.cwhich calls code fromlibxl_paths.candlibxl_bootloader.c.
...
Quoted 2 lines
-$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
+$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
This can't possibly be right. Files called "libxl_*.o" are parts of libxl and should be in libxenlight.so.
I see, however, that Stefano has already applied it.
Ian.
Quoted 4 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
Quoted 3 lines
Attached patch fixes linking error when creating the xl binary. The xl binary compiles in
xl_cmdimpl.cwhich calls code fromlibxl_paths.candlibxl_bootloader.c.
Quoted 9 lines
...
Quoted 2 lines
-$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
+$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.soThis can't possibly be right. Files called "libxl_*.o" are parts of libxl and should be in libxenlight.so.
I see, however, that Stefano has already applied it.
Yes, sorry I missed it.
Quoted 12 lines · On Wednesday 21 July 2010 18:14:14 Stefano Stabellini wrote:
Quoted 11 lines · Ian Jackson
Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
Quoted 3 lines
Attached patch fixes linking error when creating the xl binary. The xl binary compiles in
xl_cmdimpl.cwhich calls code fromlibxl_paths.candlibxl_bootloader.c....
Quoted 3 lines
-$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
Quoted 6 lines
Quoted 4 lines
This can't possibly be right. Files called "libxl_*.o" are parts of libxl and should be in libxenlight.so.
I see, however, that Stefano has already applied it.
Yes, sorry I missed it.
I realized this patch is wrong. Please apply the patch to correct this:
http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01068.html
Christoph
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632