Skip to contentSkip to conversation

x86, tlb: Correct used type

PATCH In review Borislav Petkov 1 participant 2 messages Jul 21, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, tlb: Correct used type

smp_processor_id() returns an int and not an unsigned long. Also, since the function is small enough, there's no need for a local variable caching its value.

No functionality change, just cleanup.

---
 arch/x86/mm/tlb.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/mm/tlb.c +1 -3
index 426f3a1..c03f14a 100644
@@ -278,11 +278,9 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long va)
 
 static void do_flush_tlb_all(void *info)
 {
-	unsigned long cpu = smp_processor_id();
-
 	__flush_tlb_all();
 	if (percpu_read(cpu_tlbstate.state) == TLBSTATE_LAZY)
-		leave_mm(cpu);
+		leave_mm(smp_processor_id());
 }
 
 void flush_tlb_all(void)
Signature · 12 lines
1.7.1


-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
#1 lore raw

[tip:x86/mm] x86, tlb: Clean up and correct used type

Commit-ID:  3f8afb77cd8a672f024e4a16763ef177bc16c8f8
Gitweb:     http://git.kernel.org/tip/3f8afb77cd8a672f024e4a16763ef177bc16c8f8
Author:     Borislav Petkov <[email protected]>
AuthorDate: Wed, 21 Jul 2010 14:47:05 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 21 Jul 2010 21:48:15 +0200

x86, tlb: Clean up and correct used type

smp_processor_id() returns an int and not an unsigned long. Also, since the function is small enough, there's no need for a local variable caching its value.

No functionality change, just cleanup.

LKML-Reference: <20100721124705.GA674@aftab>

---
 arch/x86/mm/tlb.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/mm/tlb.c +1 -3
index 426f3a1..c03f14a 100644
@@ -278,11 +278,9 @@ void flush_tlb_page(struct vm_area_struct *vma, unsigned long va)
 
 static void do_flush_tlb_all(void *info)
 {
-	unsigned long cpu = smp_processor_id();
-
 	__flush_tlb_all();
 	if (percpu_read(cpu_tlbstate.state) == TLBSTATE_LAZY)
-		leave_mm(cpu);
+		leave_mm(smp_processor_id());
 }
 
 void flush_tlb_all(void)