Skip to contentSkip to conversation

correct xend initscript dependency in LSB part

PATCH In review Olaf Hering 3 participants 7 messages Jul 23, 2010 – Jul 30, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 correct xend initscript dependency in LSB part

Add missing dependencies to runlevel script
xend requires at least xenstored

tools/hotplug/Linux/init.d/xend +2 -2
@@ -8,9 +8,9 @@
 # description: Starts and stops the Xen control daemon.
 ### BEGIN INIT INFO
 # Provides:          xend
-# Required-Start:    $syslog $remote_fs
+# Required-Start:    $syslog $remote_fs xenstored
 # Should-Start:
-# Required-Stop:     $syslog $remote_fs
+# Required-Stop:     $syslog $remote_fs xenstored
 # Should-Stop:
 # Default-Start:     3 4 5
 # Default-Stop:      0 1 2 6
#1 lore raw

Hi,

Quoted 2 lines · On Fri, 23 Jul 2010 08:21:20 -0400 Olaf Hering <[email protected]> wrote:

Add missing dependencies to runlevel script
xend requires at least xenstored

This change only makes sense, if there is a /etc/init.d/xenstored init-script, which I wasn't able to find in the sources.

It would be useful to change this to xencommons, which is mentioned when running the xend-script manual.

 # /etc/init.d/xend start
 xencommons should be started first.
 # /etc/init.d/xencommons start
 Starting xenstored...
 Setting domain 0 name...
 Starting xenconsoled...
 # /etc/init.d/xend start
 #

regards,
Conny Seidel

##
##################################################################
# Email : [email protected] GnuPG-Key : 0xA6AB055D #
# Fingerprint: 17C4 5DB2 7C4C C1C7 1452 8148 F139 7C09 A6AB 055D #
##################################################################
# Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach #
# General Managers: Alberto Bozzo, Andrew Bowd #
# Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen #
# HRB Nr. 43632 #
##################################################################

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#2 lore raw

Conny Seidel writes ("Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part"):

Quoted 2 lines

This change only makes sense, if there is a /etc/init.d/xenstored init-script, which I wasn't able to find in the sources.

As I understand it, Required-Start names services which are listed in the Provides of another init script, not the other script name directly. Is that not true ? Perhaps you'd like to give chapter and verse from the LSB spec.

Ian.

#6 lore raw
In reply to Conny Seidel
Quoted 10 lines · Conny Seidel

Hi,

Quoted 2 lines · On Fri, 23 Jul 2010 08:21:20 -0400 Olaf Hering <[email protected]> wrote:

Add missing dependencies to runlevel script
xend requires at least xenstored

This change only makes sense, if there is a /etc/init.d/xenstored init-script, which I wasn't able to find in the sources.

The Required/Should-Start lines reference Provides lines in other runlevel scripts, so that tools which actually create the runlevel links and their numbers can get the ordering right.

Do you see any issues with my change?

Olaf

#4 lore raw
In reply to Conny Seidel
Quoted 12 lines · Conny Seidel
Quoted 6 lines · On Fri, 30 Jul 2010 10:11:01 -0400 Ian Jackson <[email protected]>…

As I understand it, Required-Start names services which are listed in the Provides of another init script, not the other script name directly. Is that not true ? Perhaps you'd like to give chapter and verse from the LSB spec.

Ian.

Ouch, you are right on the LSB conformity. Sorry my bad.

Quoted 7 lines

But if I get an error message like this:

 # chkconfig xend on
 insserv: Service xenstored has to be enabled for service xend
 insserv: exiting now!
 /sbin/insserv failed, exit code 1

I would assume that I need to start /etc/init.d/xenstored.

insserv does not automatically enable all dependencies. An 'insserv xencommons' is required first.

Olaf

#3 lore raw
In reply to Ian Jackson
Quoted 6 lines · On Fri, 30 Jul 2010 10:11:01 -0400 Ian Jackson <[email protected]>…

As I understand it, Required-Start names services which are listed in the Provides of another init script, not the other script name directly. Is that not true ? Perhaps you'd like to give chapter and verse from the LSB spec.

Ian.

Ouch, you are right on the LSB conformity. Sorry my bad.

But if I get an error message like this:

 # chkconfig xend on
 insserv: Service xenstored has to be enabled for service xend
 insserv: exiting now!
 /sbin/insserv failed, exit code 1

I would assume that I need to start /etc/init.d/xenstored.

Conny

##
##################################################################
# Email : [email protected] GnuPG-Key : 0xA6AB055D #
# Fingerprint: 17C4 5DB2 7C4C C1C7 1452 8148 F139 7C09 A6AB 055D #
##################################################################
# Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach #
# General Managers: Alberto Bozzo, Andrew Bowd #
# Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen #
# HRB Nr. 43632 #
##################################################################

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#5 lore raw

Conny Seidel writes ("Re: [Xen-devel] [PATCH] correct xend initscript dependency in LSB part"):

Quoted 9 lines

Ouch, you are right on the LSB conformity. Sorry my bad.

But if I get an error message like this:

 # chkconfig xend on
 insserv: Service xenstored has to be enabled for service xend
 insserv: exiting now!
 /sbin/insserv failed, exit code 1

I would assume that I need to start /etc/init.d/xenstored.

I don't see what we can do about this. The xencommons script does more than xenstored - hence the name. We can't change the Requires to refer to xencommons because it won't work.

I think you need to take the unhelpfulness of the error message up with the maintainers of insserv.

Ian.